OpenNeo/impress
OpenNeo/impress
1
0
Fork 1
Code Pull requests Activity

Compare commits

base: OpenNeo:d6888f19412464068bbfbdc7bebb930156022456
Branches Tags
OpenNeo:main
OpenNeo:modeling-tests
OpenNeo:rainbow-pool
OpenNeo:simpler-item-previews
...
compare: OpenNeo:3ea0842f008f26023ed0c75f809aa2f8835d8c0a
Branches Tags
OpenNeo:main
OpenNeo:modeling-tests
OpenNeo:rainbow-pool
OpenNeo:simpler-item-previews

2 commits
d6888f1941 ... 3ea0842f00

Author SHA1 Message Date
Emi Matchu
3ea0842f00 Skip loading image hashes for "pets" that start with @ 
This is an optimization on top of 9d8f035, in which we skip the network
request altogether in this case that we know will and should fail!
 2024-04-16 10:10:28 -07:00
Emi Matchu
9d8f035360 Oops, stop crashing when modeling "pets" that start with @ 
Ahh, we recently added a step to pet loading that sends a metadata
request to `PetService.getPet`, which is now (in a sense, correctly!)
raising a `PetNotFound` error when we try modeling with a "pet" that
starts with `@` (a trick we use in situations where we can get an image
hash for a modeling situation, but not an irl pet itself).

In this change, we make it no longer a crashing issue if the pet
metadata request fails: it's not a big deal to have a `PetType` have no
image hash or not have it be up-to-date!

In the next change, I'll also add an optimization to skip fetching it
altogether in this case—but I wanted to see this work first, because
the more general resilience is more important imo!
 2024-04-16 10:03:36 -07:00
1 changed files with 8 additions and 1 deletions
Show stats Expand all files Collapse all files

9
app/models/pet.rb
View file

@ -35,7 +35,11 @@ class Pet < ApplicationRecord
color_id: pet_data[:color_id].to_i color_id: pet_data[:color_id].to_i
) )
new_image_hash = Pet.fetch_image_hash(self.name) begin
new_image_hash = Pet.fetch_image_hash(self.name)
rescue => error
Rails.logger.warn "Failed to load image hash: #{error.full_message}"
end
self.pet_type.image_hash = new_image_hash if new_image_hash.present? self.pet_type.image_hash = new_image_hash if new_image_hash.present?
# With an alt style, `body_id` in the biology data refers to the body ID of # With an alt style, `body_id` in the biology data refers to the body ID of
@ -133,6 +137,9 @@ class Pet < ApplicationRecord
end end
def self.fetch_metadata(name, timeout: 10) def self.fetch_metadata(name, timeout: 10)
# If this is an image hash "pet name", it has no metadata.
return nil if name.start_with?("@")
request = PET_SERVICE.action('getPet').request([name]) request = PET_SERVICE.action('getPet').request([name])
send_amfphp_request(request).tap do |data| send_amfphp_request(request).tap do |data|
if data[:name].blank? if data[:name].blank?