OpenNeo/impress
OpenNeo/impress
1
0
Fork 1
Code Pull requests Activity

Compare commits

base: OpenNeo:cf6921329dc4368abb33d487cb7c2e3ac234113a
Branches Tags
OpenNeo:main
OpenNeo:feature/wardrobe-v2
OpenNeo:feature/consolidate-auth-database
OpenNeo:modeling-tests
OpenNeo:rainbow-pool
OpenNeo:simpler-item-previews
...
compare: OpenNeo:2cfcfaf69dbd8f5a01347660c28960aa3a7e942f
Branches Tags
OpenNeo:main
OpenNeo:feature/wardrobe-v2
OpenNeo:feature/consolidate-auth-database
OpenNeo:modeling-tests
OpenNeo:rainbow-pool
OpenNeo:simpler-item-previews

2 commits
cf6921329d ... 2cfcfaf69d

Author SHA1 Message Date
Emi Matchu
2cfcfaf69d Rename StaticController to AboutController 
This is where `/about` pages will go now!
 2024-03-12 17:12:43 -07:00
Emi Matchu
9aef987f95 Move partials in views/static to views/application 
I think this is the more canonical place for stuff like this these days!
It's nice to be able to just say the short name when calling `render`.

Here's the answer I looked up about it: https://stackoverflow.com/a/9892081/107415

My immediate motivation is that I'm looking at creating more About
pages, and thinking about where to put them; I think maybe we trash the
`StaticController`, move these partials out to here, and move terms
into a new `AboutController`?
 2024-03-10 18:48:25 -07:00
8 changed files with 8 additions and 6 deletions
Show stats Expand all files Collapse all files

4
app/controllers/about_controller.rb Normal file
View file

@ -0,0 +1,4 @@
class AboutController < ApplicationController
def terms
end
end

2
app/controllers/static_controller.rb
View file

@ -1,2 +0,0 @@
class StaticController < ApplicationController
end

0
app/views/static/terms.html.haml → app/views/about/terms.html.haml
View file

0
app/views/static/_analytics.html.erb → app/views/application/_analytics.html.erb
View file

0
app/views/static/_announcement.html → app/views/application/_announcement.html
View file

4
app/views/layouts/application.html.haml
View file

@ -13,7 +13,7 @@
%link{href: image_path('favicon.png'), rel: 'icon'} %link{href: image_path('favicon.png'), rel: 'icon'}
= yield :stylesheets = yield :stylesheets
= stylesheet_link_tag "application" = stylesheet_link_tag "application"
= render 'static/analytics' = render 'analytics'
= yield :meta = yield :meta
= open_graph_tags = open_graph_tags
= csrf_meta_tag = csrf_meta_tag
@ -24,7 +24,7 @@
%body{:class => body_class} %body{:class => body_class}
#container #container
= yield :before_title = yield :before_title
= render 'static/announcement' = render 'announcement'
- if content_for?(:title) && show_title_header? - if content_for?(:title) && show_title_header?
%h1#title= yield :title %h1#title= yield :title
= yield :before_flashes = yield :before_flashes

2
app/views/outfits/edit.html.haml
View file

@ -17,7 +17,7 @@
%link{href: image_path('favicon.png'), rel: 'icon'} %link{href: image_path('favicon.png'), rel: 'icon'}
= stylesheet_link_tag 'fonts' = stylesheet_link_tag 'fonts'
= javascript_include_tag 'wardrobe-2020-page', defer: true = javascript_include_tag 'wardrobe-2020-page', defer: true
= render 'static/analytics' = render 'analytics'
= open_graph_tags = open_graph_tags
= csrf_meta_tags = csrf_meta_tags
= impress_2020_meta_tags = impress_2020_meta_tags

2
config/routes.rb
View file

@ -87,7 +87,7 @@ OpenneoImpressItems::Application.routes.draw do
get '/donate' => 'fundraising/campaigns#current', as: :donate get '/donate' => 'fundraising/campaigns#current', as: :donate
# Static pages! # Static pages!
get '/terms', to: "static#terms", as: :terms get '/terms', to: "about#terms", as: :terms
# Other useful lil things! # Other useful lil things!
get '/sitemap.xml' => 'sitemap#index', :as => :sitemap, :format => :xml get '/sitemap.xml' => 'sitemap#index', :as => :sitemap, :format => :xml