Add warning for "Baby Body Paint" bugs

I *think* what I'm observing is that:

1. The zone restrictions are different between these items.
2. The zone restrictions *change* when reloading the page sometimes. (I
   assume from remodeling?)
3. The items look very buggy on many pets, because many appearances
   seem to expect different zone restrictions than the item actually
   has.

I think what this means is:

1. TNT has finally unbound restricted zones from the item level, and
   allowed different appearances to have different restrictions. Neat!
2. The API still serves it the same way, as a field on the item.

So I think this means we need to update our schema to reflect the fact
that an item's `zones_restrict` field isn't *really* a property of the
item; it's a property of the combination of the item and the current
body ID.

My gut take here is that maybe this means it's time for the Large
Refactor that I've kinda been interested in for a while, but been
avoiding because of Impress 2020 compatibility issues: instead of a
`body_id` field on assets, and having them directly belong to items,
make an `ItemAppearance` record (closer to how 2020's GQL API modeled
it, I was looking ahead to this possibility!) that's keyed on item and
body ID, and assets belong to *that*.

Then, we could move the zones restriction field onto the
`ItemAppearance` record instead. And then it doesn't really matter to
us how TNT models it internally; whatever we saw is what we use.
(Again, I looked ahead to this in the 2020 app, and tried to use the
`restrictedZones` field on `ItemAppearance` when possible—even though
it secretly just reads directly from the `Item`!)

…but that's a pretty big departure from how things are modeled now, and
isn't something we can just throw together—especially coordinating it
across both apps. I was getting close to being able to shut off 2020
from a *front-facing* perspective (but still keeping a lot of the GQL
endpoints open for the wardrobe-2020 frontend), but I don't think we're
very close to being able to try to target turning off 2020's *backend*
as a prereq to this; or at least, if we do, we should expect that to
take a while. (Counting now, there's still 9 GQL queries—not as many as
I expected tbh, but still quite a few.)

So idk how to sequence this! But for now, let's put out a warning, and
start setting expectations.

app/javascript/wardrobe-2020/WardrobePage/useSearchResults.js

@@ -1,10 +1,6 @@
-import React from "react";
+import { useDebounce } from "../util";
-import gql from "graphql-tag";
-import { useQuery } from "@apollo/client";
-import { useDebounce, useLocalStorage } from "../util";
 import { useItemSearch } from "../loaders/items";
 import { emptySearchQuery, searchQueryIsEmpty } from "./SearchToolbar";
-import { itemAppearanceFragment } from "../components/useOutfitAppearance";
 import { SEARCH_PER_PAGE } from "./SearchPanel";
 
 /**
@@ -25,154 +21,21 @@ export function useSearchResults(
     initialValue: emptySearchQuery,
   });
 
-  // NOTE: This query should always load ~instantly, from the client cache.
+  const { isLoading, error, data } = useItemSearch(
-  const { data: zoneData } = useQuery(gql`
-    query SearchPanelZones {
-      allZones {
-        id
-        label
-      }
-    }
-  `);
-  const allZones = zoneData?.allZones || [];
-  const filterToZones = query.filterToZoneLabel
-    ? allZones.filter((z) => z.label === query.filterToZoneLabel)
-    : [];
-  const filterToZoneIds = filterToZones.map((z) => z.id);
-
-  const currentPageIndex = currentPageNumber - 1;
-  const offset = currentPageIndex * SEARCH_PER_PAGE;
-
-  // Until the new item search is ready, we can toggle between them! Use
-  // `setItemSearchQueryMode` in the JS console to choose "gql" or "new".
-  const [queryMode, setQueryMode] = useLocalStorage(
-    "DTIItemSearchQueryMode",
-    "gql",
-  );
-  React.useEffect(() => {
-    window.setItemSearchQueryMode = setQueryMode;
-  }, [setQueryMode]);
-
-  const {
-    loading: loadingGQL,
-    error: errorGQL,
-    data: dataGQL,
-  } = useQuery(
-    gql`
-      query SearchPanel(
-        $query: String!
-        $fitsPet: FitsPetSearchFilter
-        $itemKind: ItemKindSearchFilter
-        $currentUserOwnsOrWants: OwnsOrWants
-        $zoneIds: [ID!]!
-        $speciesId: ID!
-        $colorId: ID!
-        $altStyleId: ID
-        $offset: Int!
-        $perPage: Int!
-      ) {
-        itemSearch: itemSearchV2(
-          query: $query
-          fitsPet: $fitsPet
-          itemKind: $itemKind
-          currentUserOwnsOrWants: $currentUserOwnsOrWants
-          zoneIds: $zoneIds
-        ) {
-          id
-          numTotalItems
-          items(offset: $offset, limit: $perPage) {
-            # TODO: De-dupe this from useOutfitState?
-            id
-            name
-            thumbnailUrl
-            isNc
-            isPb
-            currentUserOwnsThis
-            currentUserWantsThis
-
-            appearanceOn(
-              speciesId: $speciesId
-              colorId: $colorId
-              altStyleId: $altStyleId
-            ) {
-              # This enables us to quickly show the item when the user clicks it!
-              ...ItemAppearanceForOutfitPreview
-
-              # This is used to group items by zone, and to detect conflicts when
-              # wearing a new item.
-              layers {
-                zone {
-                  id
-                  label
-                }
-              }
-              restrictedZones {
-                id
-                label
-                isCommonlyUsedByItems
-              }
-            }
-          }
-        }
-      }
-      ${itemAppearanceFragment}
-    `,
-    {
-      variables: {
-        query: debouncedQuery.value,
-        fitsPet: { speciesId, colorId, altStyleId },
-        itemKind: debouncedQuery.filterToItemKind,
-        currentUserOwnsOrWants: debouncedQuery.filterToCurrentUserOwnsOrWants,
-        zoneIds: filterToZoneIds,
-        speciesId,
-        colorId,
-        altStyleId,
-        offset,
-        perPage: SEARCH_PER_PAGE,
-      },
-      context: { sendAuth: true },
-      skip:
-        skip ||
-        queryMode !== "gql" ||
-        (!debouncedQuery.value &&
-          !debouncedQuery.filterToItemKind &&
-          !debouncedQuery.filterToZoneLabel &&
-          !debouncedQuery.filterToCurrentUserOwnsOrWants),
-      onError: (e) => {
-        console.error("Error loading search results", e);
-      },
-      // Return `numTotalItems` from the GQL cache while waiting for next page!
-      returnPartialData: true,
-    },
-  );
-
-  const {
-    isLoading: loadingQuery,
-    error: errorQuery,
-    data: dataQuery,
-  } = useItemSearch(
     {
       filters: buildSearchFilters(debouncedQuery, outfitState),
       withAppearancesFor: { speciesId, colorId, altStyleId },
-      page: currentPageIndex + 1,
+      page: currentPageNumber,
       perPage: SEARCH_PER_PAGE,
     },
     {
-      enabled:
+      enabled: !skip && !searchQueryIsEmpty(debouncedQuery),
-        !skip && queryMode === "new" && !searchQueryIsEmpty(debouncedQuery),
     },
   );
 
-  const loading =
+  const loading = debouncedQuery !== query || isLoading;
-    debouncedQuery !== query ||
+  const items = data?.items ?? [];
-    (queryMode === "gql" ? loadingGQL : loadingQuery);
+  const numTotalPages = data?.numTotalPages ?? 0;
-  const error = queryMode === "gql" ? errorGQL : errorQuery;
-  const items =
-    (queryMode === "gql" ? dataGQL?.itemSearch?.items : dataQuery?.items) ?? [];
-  const numTotalPages =
-    (queryMode === "gql"
-      ? Math.ceil((dataGQL?.itemSearch?.numTotalItems ?? 0) / SEARCH_PER_PAGE)
-      : dataQuery?.numTotalPages) ?? 0;
 
   return { loading, error, items, numTotalPages };
 }

app/javascript/wardrobe-2020/loaders/items.js

@@ -98,7 +98,6 @@ async function loadItemSearch(searchOptions) {
 
 	return result;
 }
-window.loadItemSearch = loadItemSearch;
 
 /**
  * writeItemToApolloCache is one last important bridge between our loaders and

app/views/items/show.html.haml

@@ -6,6 +6,13 @@
     current_user_lists: @current_user_lists,
     current_user_quantities: @current_user_quantities}
 
+- if @item.name.include? "Baby Body Paint"
+  %p.warning
+    The Baby Body Paint items seem to have new zone restriction rules that our
+    system doesn't support yet, whuh oh! This might require major changes to
+    how we handle zones. Until then, these items will be <em>very</em> buggy,
+    sorry!
+
 #outfit-preview-root{'data-item-id': @item.id}
 
 - unless @contributors_with_counts.empty?