Commit graph

73 commits

Author SHA1 Message Date
3c127569fe stop caching item preview species images, and fix the bad query instead
Most of the reasoning is documented in the big comment. In short, we tried
to solve the problem with caching, but the caching should hardly be necessary
now that the bottleneck should be fixed. We'll see on production if it
actually solves the whole problem, but I've confirmed in the console that
redefining this function makes random_basic_per_species (as called during
rendering) a ton faster. And this way we keep our randomness, woo!
2013-06-23 22:35:27 -07:00
816584f177 Move item_link partial caching to a helper rather than the template itself
This is a surprisingly huge performance gain. On my testing (with
cache_classes set to true to also cache templates), this sped up
closet_hangers#index rendering by a factor of 2 when there were a
significant number of items. Cool beans.

I think we can even hold off on the individual hanger caching now:
we've made the closet hanger partial tons faster by moving forms out
of them and doing this cache check earlier. I'm expecting significant
performance gains both here and on items#index (though less so there).
I'll deploy and see how much it helps in production; if not enough, we
can look at the layered caching of hangers, lists, groups, full pages,
etc.

So glad we don't *have* to move to a pagination model!
2013-06-22 16:31:46 -07:00
f1aca20185 stop including ?q= in _item_link links: it's getting cached, so is almost always wrong 2013-06-21 19:43:11 -07:00
154bdd5d0d cache item-preview-species on items#show
items#show has been very slow recently, and I think it's because there's a lot
of querying to be done. Another option would have been to attempt to
short-circuit Item#supported_species if not body specific, but that would
still leave us with 1s load times for body specific items, which is not
satisfactory. The short-circuiting might still be worth doing, but probably
not now.

I'm also not sure that this is actually the core performance problem, but
we'll see. It definitely helped on the dev server: items#show took about
200ms on item pages where everything but species images were cached, then
took about 30ms on subsequent loads. Looking like a good candidate.
2013-06-21 19:30:41 -07:00
26ac3782ec move zones to database 2013-01-24 18:26:00 -06:00
70ff4974a3 refactor items.show for hierarchy and twl 2013-01-24 18:23:21 -06:00
0cbdc30a15 refactor items.index for hierarchy and twl 2013-01-24 18:23:21 -06:00
706fad0174 localize items#item_link cache 2013-01-24 18:23:20 -06:00
ac0490dc1d i18n for items#show (including javascripts/items/show.js) 2013-01-24 18:23:19 -06:00
5e89e2b947 i18n for items#index (and layouts#items) 2013-01-24 18:23:18 -06:00
07f49307f1 a few tweaks to items#show contributors appearance 2012-10-24 22:16:01 -05:00
f56b544963 brought-to-you-by on items#show lists contributors 2012-10-24 22:09:05 -05:00
e9e7d305f0 retire neoitems links, replace with jn items links 2012-10-21 15:57:17 -05:00
412c401c5f better cache items#show 2012-08-10 00:02:11 -04:00
f6d34841ec cache newest items on homepage and items#index 2012-08-09 22:35:30 -04:00
1e3938eea9 improve closet performance by caching item link 2012-08-09 19:34:56 -04:00
c7c8f3a78e oops. accidentally used trading post url for auctions. fixed 2012-05-23 20:12:17 -04:00
4451800e42 added shop wiz, etc., links to NP item show page 2012-05-23 20:09:35 -04:00
99a7558dd9 update items#show style 2012-03-23 16:48:00 -05:00
44156c5b21 can now have the same item in more than one list 2012-03-23 16:25:10 -05:00
d99a1ad792 newest items 2011-08-04 10:01:44 -04:00
8bf9872fbe stop caching items#show for now due to Your Items module 2011-08-02 00:12:44 -04:00
ea7171b322 fix ambiguous item_link partial throwing errors in outfits#show 2011-07-31 23:45:57 -04:00
137aeac8d4 show traders on items#show 2011-07-31 00:19:28 -04:00
9a7b13dc5d drag and drop on Your Items <3 2011-07-30 13:40:41 -04:00
358840076c closet lists, round one 2011-07-29 10:52:04 -04:00
e6c419c7e0 give user paths a canonical tag 2011-07-26 18:56:14 -04:00
6d155ecaf1 show owned/wanted icons and search filters 2011-07-22 16:52:40 -04:00
85af53417b distinguish between owning and wanting an item 2011-07-22 15:35:38 -04:00
f2d6a454c5 explain user:owns on item search 2011-07-17 17:28:45 -04:00
e6020a5cfe simplify closeting item 2011-07-15 16:32:05 -04:00
47e3b72937 restructure backend of closet hanger quantity updates 2011-07-15 16:16:40 -04:00
fab612950a basic hanger interface from item 2011-07-14 13:56:44 -04:00
3a193d534d closeted icon, all over the place 2011-07-14 13:56:44 -04:00
d5641dddbb user closet display 2011-07-14 13:56:20 -04:00
3b7f158890 cache just content on items, not action, so we can still use title and canonical 2011-05-20 20:23:37 -04:00
c18a333bd2 pretty item urls 2011-05-20 19:29:04 -04:00
1b3669178c xss vulnerability in empty search results page 2011-05-13 08:20:09 -04:00
c23024b43a add item name to title 2011-05-13 08:07:59 -04:00
d48bbdecfa put items search query in title 2011-05-13 08:07:20 -04:00
648649f5cc support special colors in the infinite closet 2011-05-02 18:07:56 -04:00
8d20a68a53 remove need for content_for in items/show caching 2010-12-08 21:14:24 -05:00
b7fb5a952b Revert "implement head.js"
This reverts commit 12ffa33f4f.
2010-12-06 18:50:13 -05:00
12ffa33f4f implement head.js 2010-12-05 21:18:52 -05:00
3d29f7784f asset spider, yaaay 2010-11-27 18:41:06 -05:00
0f5d36bcb6 remove hard-coded references to impress.openneo.net 2010-11-15 15:40:34 -05:00
ef004cc6cb needed objects 2010-11-06 13:07:12 -04:00
e40d4601d8 a functioning wardrobe 2010-10-10 22:18:42 -04:00
1952bcb560 fix typo in is:pb homepage note 2010-10-03 20:23:45 -04:00
bff366d417 add is:pb description to home page 2010-10-03 20:21:46 -04:00