OpenNeo/impress
OpenNeo/impress
1
0
Fork 1
Code Pull requests Activity

Handle crash on new item page when SWF asset has no image available

Browse source
This commit is contained in:
Emi Matchu 2024-09-06 17:57:18 -07:00
parent 052c02f841
commit c9f2d660bc
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/assets/javascripts/outfit-viewer.js
View file

@ -112,9 +112,7 @@ class OutfitLayer extends HTMLElement {
this.#setStatus("error"), this.#setStatus("error"),
); );
} else { } else {
throw new Error( console.warn(`<outfit-layer> contained no image or iframe: `, this);
`<outfit-layer> must contain an <img> or <iframe> tag`,
);
} }
} }

4
app/views/items/_outfit_viewer.html.haml
View file

@ -20,5 +20,7 @@
} }
- if swf_asset.canvas_movie? - if swf_asset.canvas_movie?
%iframe{src: swf_asset_path(swf_asset, playing: outfit_viewer_is_playing ? true : nil)} %iframe{src: swf_asset_path(swf_asset, playing: outfit_viewer_is_playing ? true : nil)}
- else - elsif swf_asset.image_url.present?
= image_tag swf_asset.image_url, alt: "" = image_tag swf_asset.image_url, alt: ""
- else
/ No movie or image available for SWF asset: #{swf_asset.url}