OpenNeo/impress
OpenNeo/impress
1
0
Fork 1
Code Pull requests Activity

Oops, fix bug with empty subtitles in Item Getting Guide

Browse source 
Oh weird, even with `flush: true`, `content_for` will ignore an empty
block and *not* flush out the previous content. This could cause rows
whose subtitles *should* have been empty (e.g. no NC trade value) to
display the previous row's value instead.

Let's make this whole situation a bit more robust by having the
*template* clear out the subtitle right before calling the block. That
way, a previous row's value *can't* get in, no matter what.
This commit is contained in:
Emi Matchu 2024-06-09 15:40:58 -07:00
parent 3dbcf41e4f
commit be525d1d67
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/views/items/_item_list_row.html.haml
View file

@ -1,4 +1,6 @@
-# Run the block first, so we can get the subtitle content if provided! -# Run the block first, so we can get the subtitle content if provided! Clear
-# out any old values beforehand, too.
- content_for :subtitle, "", flush: true
- content = yield - content = yield
- subtitle = yield :subtitle - subtitle = yield :subtitle