From b1890d4f6f64014908e9137fbf8de776675bb53e Mon Sep 17 00:00:00 2001 From: Emi Matchu Date: Thu, 24 Oct 2024 15:16:55 -0700 Subject: [PATCH] Refactor existing modeling tests to follow more RSpec-y syntax I'm learning how to group things and stuff! --- spec/models/pet_spec.rb | 120 ++++++++++++++++++++-------------------- 1 file changed, 59 insertions(+), 61 deletions(-) diff --git a/spec/models/pet_spec.rb b/spec/models/pet_spec.rb index ab1c1320..d0352cee 100644 --- a/spec/models/pet_spec.rb +++ b/spec/models/pet_spec.rb @@ -9,74 +9,72 @@ RSpec.describe Pet, type: :model do context "for thyassa, the Purple Chia" do subject(:pet) { Pet.load "thyassa" } - it "is named thyassa" do - expect(pet.name).to eq("thyassa") + it("is named thyassa") { expect(pet.name).to eq("thyassa") } + it("has no items") { expect(pet.items).to be_empty } + + describe "its pet type" do + subject(:pet_type) { pet.pet_type } + + it("is new and unsaved") { should be_new_record } + it("is Purple") { expect(pet_type.color).to eq Color.find_by_name!("purple") } + it("is a Chia") { expect(pet_type.species).to eq Species.find_by_name!("chia") } + it("has the standard Chia body") { expect(pet_type.body_id).to eq 212 } + it("uses the pet's image hash") { expect(pet_type.image_hash).to eq "m:thyass" } + + it("is saved when saving the pet") do + expect { pet.save! }.to change { pet_type.persisted? }.from(false).to(true) + end end - it "has no items" do - expect(pet.items).to be_empty - end + describe "its pet state" do + subject(:pet_state) { pet.pet_state } - it "has a new Purple Chia pet type" do - expect(pet.pet_type.new_record?).to be true - expect(pet.pet_type.color).to eq Color.find_by_name!("purple") - expect(pet.pet_type.species).to eq Species.find_by_name!("chia") - expect(pet.pet_type.body_id).to eq 212 - expect(pet.pet_type.image_hash).to eq "m:thyass" - end + it("is new and unsaved") { should be_new_record } + it("belongs to the pet's pet type") { expect(pet_state.pet_type).to eq pet.pet_type } + it("isn't labeled yet") { expect(pet_state.pose).to eq "UNKNOWN" } - it "has a new unlabeled Purple Chia pet state" do - expect(pet.pet_state.new_record?).to be true - expect(pet.pet_state.color).to eq Color.find_by_name!("purple") - expect(pet.pet_state.species).to eq Species.find_by_name!("chia") - expect(pet.pet_state.pose).to eq "UNKNOWN" - end + it "is saved when saving the pet" do + expect { pet.save! }.to change { pet_state.persisted? }.from(false).to(true) + end - it "has new assets for the biology layers" do - pet.save! # TODO: I wish this were set up before saving. + it "has new biology assets" do + pet.save! # TODO: I wish this were set up before saving. - expect(pet.pet_state.swf_assets).to contain_exactly( - a_record_matching( - type: "biology", - remote_id: 10083, - zone_id: 37, - url: "https://images.neopets.com/cp/bio/swf/000/000/010/10083_8a1111a13f.swf", - manifest_url: "https://images.neopets.com/cp/bio/data/000/000/010/10083_8a1111a13f/manifest.json", - zones_restrict: "0000000000000000000000000000000000000000000000000000", - ), - a_record_matching( - type: "biology", - remote_id: 11613, - zone_id: 15, - url: "https://images.neopets.com/cp/bio/swf/000/000/011/11613_f7d8d377ab.swf", - manifest_url: "https://images.neopets.com/cp/bio/data/000/000/011/11613_f7d8d377ab/manifest.json", - zones_restrict: "0000000000000000000000000000000000000000000000000000", - ), - a_record_matching( - type: "biology", - remote_id: 14187, - zone_id: 34, - url: "https://images.neopets.com/cp/bio/swf/000/000/014/14187_0e65c2082f.swf", - manifest_url: "https://images.neopets.com/cp/bio/data/000/000/014/14187_0e65c2082f/manifest.json", - zones_restrict: "0000000000000000000000000000000000000000000000000000", - ), - a_record_matching( - type: "biology", - remote_id: 14189, - zone_id: 33, - url: "https://images.neopets.com/cp/bio/swf/000/000/014/14189_102e4991e9.swf", - manifest_url: "https://images.neopets.com/cp/bio/data/000/000/014/14189_102e4991e9/manifest.json", - zones_restrict: "0000000000000000000000000000000000000000000000000000", + expect(pet_state.swf_assets).to contain_exactly( + a_record_matching( + type: "biology", + remote_id: 10083, + zone_id: 37, + url: "https://images.neopets.com/cp/bio/swf/000/000/010/10083_8a1111a13f.swf", + manifest_url: "https://images.neopets.com/cp/bio/data/000/000/010/10083_8a1111a13f/manifest.json", + zones_restrict: "0000000000000000000000000000000000000000000000000000", + ), + a_record_matching( + type: "biology", + remote_id: 11613, + zone_id: 15, + url: "https://images.neopets.com/cp/bio/swf/000/000/011/11613_f7d8d377ab.swf", + manifest_url: "https://images.neopets.com/cp/bio/data/000/000/011/11613_f7d8d377ab/manifest.json", + zones_restrict: "0000000000000000000000000000000000000000000000000000", + ), + a_record_matching( + type: "biology", + remote_id: 14187, + zone_id: 34, + url: "https://images.neopets.com/cp/bio/swf/000/000/014/14187_0e65c2082f.swf", + manifest_url: "https://images.neopets.com/cp/bio/data/000/000/014/14187_0e65c2082f/manifest.json", + zones_restrict: "0000000000000000000000000000000000000000000000000000", + ), + a_record_matching( + type: "biology", + remote_id: 14189, + zone_id: 33, + url: "https://images.neopets.com/cp/bio/swf/000/000/014/14189_102e4991e9.swf", + manifest_url: "https://images.neopets.com/cp/bio/data/000/000/014/14189_102e4991e9/manifest.json", + zones_restrict: "0000000000000000000000000000000000000000000000000000", + ) ) - ) - end - - it "saves the pet type when saved" do - expect { pet.save! }.to change { pet.pet_type.persisted? }.from(false).to(true) - end - - it "saves the pet state when saved" do - expect { pet.save! }.to change { pet.pet_state.persisted? }.from(false).to(true) + end end context "when modeled a second time" do