OpenNeo/impress
OpenNeo/impress
1
0
Fork 1
Code Pull requests Activity

in item queries, ignore name filters that are too small or too large

Browse source
This commit is contained in:
Emi Matchu 2013-03-29 17:05:14 -05:00
parent d7c027718d
commit 9d3acf660c
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/models/item/search/query.rb
View file

@ -61,8 +61,17 @@ class Item
# it to each name entry instead. I also feel bad doing this # it to each name entry instead. I also feel bad doing this
# afterwards, since it's kinda the field's job to return proper flex # afterwards, since it's kinda the field's job to return proper flex
# params, but that's a refactor for another day. # params, but that's a refactor for another day.
valid_name_lengths = (3..16)
[:_names, :_negative_names].each do |key| [:_names, :_negative_names].each do |key|
if final_flex_params[key] if final_flex_params[key]
# This part is also kinda weak. Oh well. Maybe we need
# NGramField that inherits from SetField while also applying
# these restrictions? Remove all name filters that are too
# small or too large.
final_flex_params[key].select! do |name_query|
valid_name_lengths.include?(name_query[:name].length)
end
final_flex_params[key].each do |name_query| final_flex_params[key].each do |name_query|
name_query[:fields] = locale_entries name_query[:fields] = locale_entries
end end