OpenNeo/impress
OpenNeo/impress
1
0
Fork 1
Code Pull requests Activity

Oops, fix bug preventing new alt styles from being saved

Browse source 
Whoops, I didn't realize this change I made to validation for the alt
style editing form, was goofing up alt style modeling!

The trick is, the validation was happening before the `before_create`
hook. Now I've reformulated these as `before_validation` hooks, so
we're not rejecting new alt styles for having no thumbnail!
This commit is contained in:
Emi Matchu 2024-10-18 17:04:26 -07:00
parent bb83f6fd36
commit 89c729ecbe
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/models/alt_style.rb
View file

@ -12,8 +12,8 @@ class AltStyle < ApplicationRecord
validates :series_name, presence: true, allow_nil: true validates :series_name, presence: true, allow_nil: true
validates :thumbnail_url, presence: true validates :thumbnail_url, presence: true
before_create :infer_series_name before_validation :infer_series_name, unless: :has_real_series_name?
before_create :infer_thumbnail_url before_validation :infer_thumbnail_url, unless: :thumbnail_url?
scope :matching_name, ->(series_name, color_name, species_name) { scope :matching_name, ->(series_name, color_name, species_name) {
color = Color.find_by_name!(color_name) color = Color.find_by_name!(color_name)
@ -82,7 +82,7 @@ class AltStyle < ApplicationRecord
# embarrassing. # embarrassing.
NOSTALGIC_FINAL_DAY = Date.new(2024, 12, 31) NOSTALGIC_FINAL_DAY = Date.new(2024, 12, 31)
def infer_series_name def infer_series_name
if !has_real_series_name? && Date.today <= NOSTALGIC_FINAL_DAY if Date.today <= NOSTALGIC_FINAL_DAY
self.series_name = "Nostalgic" self.series_name = "Nostalgic"
end end
end end