OpenNeo/impress
OpenNeo/impress
1
0
Fork 1
Code Pull requests Activity

Handle iframe outright failing to load in new item page preview

Browse source 
This is a nice extra error handler to have, but note that it *won't*
catch the case where the iframe successfully loads but the page returns
a bad status code. In this case, we'll just show the loading state
forever.
This commit is contained in:
Emi Matchu 2024-07-08 10:44:01 -07:00
parent fcad7e2bc9
commit 7688caebe1
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/assets/javascripts/outfit-viewer.js
View file

@ -34,6 +34,7 @@ class OutfitLayer extends HTMLElement {
} else if (iframe) { } else if (iframe) {
this.iframe = iframe; this.iframe = iframe;
window.addEventListener("message", (m) => this.#onMessage(m)); window.addEventListener("message", (m) => this.#onMessage(m));
this.iframe.addEventListener("error", () => this.#setStatus("error"));
this.#setStatus("loading"); this.#setStatus("loading");
} else { } else {
throw new Error(`<outfit-layer> must contain an <img> or <iframe> tag`); throw new Error(`<outfit-layer> must contain an <img> or <iframe> tag`);