Remove some silly view template caching calls

When I was trying to debug slow view code one time long long ago, I was
like "let's cache any part of the template that's static!"

And like. no that's silly, I don't trust that this speeds anything up,
but it _definitely_ adds complexity. Let's just not.
This commit is contained in:
Emi Matchu 2024-09-20 18:08:11 -07:00
parent 1f53615654
commit 73e0b3bb3c
4 changed files with 125 additions and 132 deletions

View file

@ -9,24 +9,23 @@
= will_paginate @items = will_paginate @items
- else - else
#search-info #search-info
- localized_cache :action_suffix => 'search_help' do #search-help
#search-help %h2= t '.search_help_header'
%h2= t '.search_help_header' %dl
%dl %dt= t '.examples.basic.query'
%dt= t '.examples.basic.query' %dd= t '.examples.basic.description'
%dd= t '.examples.basic.description' %dt= t '.examples.user_items.query'
%dt= t '.examples.user_items.query' %dd
%dd = twl '.examples.user_items.description',
= twl '.examples.user_items.description', :user_items_link_url => your_items_path
:user_items_link_url => your_items_path %dt= t '.examples.nc.query'
%dt= t '.examples.nc.query' %dd= t '.examples.nc.description'
%dd= t '.examples.nc.description' %dt= t '.examples.pb.query'
%dt= t '.examples.pb.query' %dd= t '.examples.pb.description'
%dd= t '.examples.pb.description' %dt= t '.examples.species.query'
%dt= t '.examples.species.query' %dd= t '.examples.species.description'
%dd= t '.examples.species.description' %dt= t '.examples.type.query'
%dt= t '.examples.type.query' %dd= t '.examples.type.description'
%dd= t '.examples.type.description'
#search-new-items #search-new-items
%h2= t '.newest_items.header' %h2= t '.newest_items.header'

View file

@ -16,52 +16,51 @@
= f.select :list_id, neopets_page_list_options(current_user) = f.select :list_id, neopets_page_list_options(current_user)
= f.submit t('.submit') = f.submit t('.submit')
- localized_cache :action_suffix => 'explanation' do %p
%p = t '.help.welcome', :name => @import_task.page.name
= t '.help.welcome', :name => @import_task.page.name = t '.help.intro', :name => @import_task.page.name
= t '.help.intro', :name => @import_task.page.name
%ol %ol
%li %li
= twl '.help.check_frame.header', :page_link_url => @import_task.page.url, = twl '.help.check_frame.header', :page_link_url => @import_task.page.url,
:name => @import_task.page.name, :index => @import_task.page.expected_index :name => @import_task.page.name, :index => @import_task.page.expected_index
%ul %ul
%li %li
%strong= t '.help.check_frame.check_login.summary' %strong= t '.help.check_frame.check_login.summary'
= t '.help.check_frame.check_login.details' = t '.help.check_frame.check_login.details'
%li %li
%strong %strong
= twl '.help.check_frame.login.summary', = twl '.help.check_frame.login.summary',
:login_link_url => neopets_login_url
= twl '.help.check_frame.login.details',
:login_link_url => neopets_login_url :login_link_url => neopets_login_url
%li = twl '.help.check_frame.login.details',
%strong :login_link_url => neopets_login_url
= t '.help.check_frame.check_content.summary', %li
:name => @import_task.page.name %strong
= t '.help.check_frame.check_content.details' = t '.help.check_frame.check_content.summary',
:name => @import_task.page.name
= t '.help.check_frame.check_content.details'
%li %li
= t '.help.view_source.header' = t '.help.view_source.header'
%ul %ul
%li %li
= t '.help.view_source.chrome_html' = t '.help.view_source.chrome_html'
%li %li
= t '.help.view_source.firefox_html' = t '.help.view_source.firefox_html'
%li %li
= t '.help.view_source.other' = t '.help.view_source.other'
%li %li
= twl '.help.view_source.troubleshooting', = twl '.help.view_source.troubleshooting',
:page_link_url => @import_task.page.url :page_link_url => @import_task.page.url
%li %li
= t '.help.copy_source.header' = t '.help.copy_source.header'
%ul %ul
%li %li
= t '.help.copy_source.shortcuts' = t '.help.copy_source.shortcuts'
%li %li
= t '.help.submit.header' = t '.help.submit.header'
%ul %ul
%li %li
= t '.help.submit.description', :name => @import_task.page.name = t '.help.submit.description', :name => @import_task.page.name

View file

@ -22,12 +22,11 @@
DTI here for a long time to come! DTI here for a long time to come!
#outfit-forms #outfit-forms
- localized_cache :action_suffix => 'outfit_forms_intro' do #pet-preview
#pet-preview = image_tag 'default_preview.png', :alt => ''
= image_tag 'default_preview.png', :alt => '' %span
%span %h1= t 'app_name'
%h1= t 'app_name' %h2= t '.tagline'
%h2= t '.tagline'
= form_tag load_pet_path, method: 'POST', class: 'primary load-pet-to-wardrobe' do = form_tag load_pet_path, method: 'POST', class: 'primary load-pet-to-wardrobe' do
= hidden_field_tag 'destination', 'wardrobe' = hidden_field_tag 'destination', 'wardrobe'
@ -109,19 +108,17 @@
= image_tag item.thumbnail_url = image_tag item.thumbnail_url
= nc_icon_for(item) = nc_icon_for(item)
%script#pet-query-notice-template{:type => 'text/x-jquery-tmpl'}
.notice
%img.inline-image{:src => '${pet_image_url}'}
= t '.pet_query.notice_html', :pet_name => '${pet_name}'
- localized_cache :action_suffix => 'templates' do %script#preview-pet-type-not-found-template{:type => 'text/x-jquery-tmpl'}
%script#pet-query-notice-template{:type => 'text/x-jquery-tmpl'} = t '.preview.pet_type_not_found', :color_name => '${color_name}',
.notice :species_name => '${species_name}'
%img.inline-image{:src => '${pet_image_url}'}
= t '.pet_query.notice_html', :pet_name => '${pet_name}'
%script#preview-pet-type-not-found-template{:type => 'text/x-jquery-tmpl'} %script#preview-pet-not-found-template{:type => 'text/x-jquery-tmpl'}
= t '.preview.pet_type_not_found', :color_name => '${color_name}', = t '.preview.pet_not_found'
:species_name => '${species_name}'
%script#preview-pet-not-found-template{:type => 'text/x-jquery-tmpl'}
= t '.preview.pet_not_found'
- content_for :javascripts do - content_for :javascripts do
= include_javascript_libraries :jquery, :jquery_tmpl = include_javascript_libraries :jquery, :jquery_tmpl

View file

@ -1,57 +1,55 @@
- title t('modeling_hub') - title t('modeling_hub')
= form_tag load_pet_path, :id => 'bulk-pets-form' do = form_tag load_pet_path, :id => 'bulk-pets-form' do
- localized_cache :action_suffix => 'bulk_pets_content' do %p= t '.explanation'
%p= t '.explanation'
= origin_tag bulk_pets_path = origin_tag bulk_pets_path
%div.noscript %div.noscript
%input{:name => "name", :type => "text"}/ %input{:name => "name", :type => "text"}/
%input{:type => "submit", :value => t('.submit')}/ %input{:type => "submit", :value => t('.submit')}/
%div.script-only %div.script-only
%textarea %textarea
%button#bulk-pets-form-add{:type => "button"}= t '.add' %button#bulk-pets-form-add{:type => "button"}= t '.add'
%button#bulk-pets-form-clear{:type => "button"}= t '.clear' %button#bulk-pets-form-clear{:type => "button"}= t '.clear'
%ul %ul
- localized_cache :action_suffix => 'templates' do %script#item-template{:type => 'text/x-jquery-tmpl'}
%script#item-template{:type => 'text/x-jquery-tmpl'} %li{:class => 'object{{if owned}} owned{{/if}}'}
%li{:class => 'object{{if owned}} owned{{/if}}'} = link_to item_path(':id').sub(':id', '${id}') do
= link_to item_path(':id').sub(':id', '${id}') do %img{:src => '${thumbnail_url}', :alt => '${description}', :title => '${description}'}
%img{:src => '${thumbnail_url}', :alt => '${description}', :title => '${description}'} %span.name ${name}
%span.name ${name}
{{if nc}} {{if nc}}
= nc_icon = nc_icon
{{/if}} {{/if}}
.closeted-icons
{{if owned}}
= owned_icon
{{/if}}
{{if wanted}}
= wanted_icon
{{/if}}
.closeted-icons
{{if owned}} {{if owned}}
%span.object-owned= t '.needed_items.item_owned' = owned_icon
{{/if}} {{/if}}
%script#needed-items-pet-header-template{:type => 'text/x-jquery/tmpl'} {{if wanted}}
= t '.needed_items.pet_header', :pet_name => '${pet_name}' = wanted_icon
{{/if}}
%script#bulk-pets-submission-template{:type => 'text/x-jquery/tmpl'} {{if owned}}
%li.waiting %span.object-owned= t '.needed_items.item_owned'
%img{:src => '${pet_thumbnail}'} {{/if}}
%span.name ${pet_name}
%span.waiting-message= t '.waiting'
%span.loading-message= t '.loading'
%span.response
%script#bulk-pets-submission-success-template{:type => 'text/x-jquery/tmpl'} %script#needed-items-pet-header-template{:type => 'text/x-jquery/tmpl'}
= t '.submission_success', :points => '${points}' = t '.needed_items.pet_header', :pet_name => '${pet_name}'
%script#bulk-pets-submission-template{:type => 'text/x-jquery/tmpl'}
%li.waiting
%img{:src => '${pet_thumbnail}'}
%span.name ${pet_name}
%span.waiting-message= t '.waiting'
%span.loading-message= t '.loading'
%span.response
%script#bulk-pets-submission-success-template{:type => 'text/x-jquery/tmpl'}
= t '.submission_success', :points => '${points}'
- content_for :javascripts do - content_for :javascripts do
= include_javascript_libraries :jquery, :jquery_tmpl = include_javascript_libraries :jquery, :jquery_tmpl