OpenNeo/impress
OpenNeo/impress
1
0
Fork 1
Code Pull requests Activity

Fix the two-line case for show more/less

Browse source 
I made two mistakes here! One is that you need to round up subpixel
line heights, and the other is that `clientHeight` is what I want, I
shouldn't include the margin!
This commit is contained in:
Emi Matchu 2024-01-19 04:35:44 -08:00
parent 4c809a5f5f
commit 68578aa929
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/javascript/item-page.js
View file

@ -19,9 +19,9 @@ try {
const tradeSections = document.querySelectorAll("#trade-hangers p"); const tradeSections = document.querySelectorAll("#trade-hangers p");
for (const section of tradeSections) { for (const section of tradeSections) {
const oneLine = parseFloat(getComputedStyle(section)['line-height']); const oneLine = parseFloat(getComputedStyle(section)['line-height']);
const maxHeight = oneLine * 2; const maxHeight = Math.ceil(oneLine * 2);
if (section.offsetHeight > maxHeight) { if (section.clientHeight > maxHeight) {
section.style.maxHeight = `${maxHeight}px`; section.style.maxHeight = `${maxHeight}px`;
section.setAttribute("data-overflows", ""); section.setAttribute("data-overflows", "");
} }