OpenNeo/impress
OpenNeo/impress
1
0
Fork 1
Code Pull requests Activity

Remove the pending marker on some modeling tests

Browse source
This commit is contained in:
Emi Matchu 2024-11-02 21:39:34 -07:00
parent f81415d327
commit 6402e5abc3
1 changed files with 10 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
spec/models/pet_spec.rb
View file

@ -32,17 +32,10 @@ RSpec.describe Pet, type: :model do
it("is saved when saving the pet") { pet.save!; should be_persisted } it("is saved when saving the pet") { pet.save!; should be_persisted }
describe "its biology assets" do describe "its biology assets" do
# TODO: I wish biology assets were set up before saving.
# Once we change this, we can un-mark some tests as pending.
before { pet.save! }
subject(:biology_assets) { pet_state.swf_assets } subject(:biology_assets) { pet_state.swf_assets }
let(:asset_ids) { biology_assets.map(&:remote_id) } let(:asset_ids) { biology_assets.map(&:remote_id) }
they("are all new") do they("are all new") { should all be_new_record }
pending("Currently, pets must be saved before assets are assigned.")
should all be_new_record
end
they("match the expected IDs") do they("match the expected IDs") do
expect(asset_ids).to contain_exactly(10083, 11613, 14187, 14189) expect(asset_ids).to contain_exactly(10083, 11613, 14187, 14189)
end end
@ -144,16 +137,18 @@ RSpec.describe Pet, type: :model do
it("is saved when saving the pet") { new_pet.save!; should be_persisted } it("is saved when saving the pet") { new_pet.save!; should be_persisted }
describe "its biology assets" do describe "its biology assets" do
# TODO: I wish biology assets were set up before saving.
# Once we change this, we can un-mark some tests as pending.
before { new_pet.save! }
subject(:biology_assets) { pet_state.swf_assets } subject(:biology_assets) { pet_state.swf_assets }
let(:asset_ids) { biology_assets.map(&:remote_id) } let(:asset_ids) { biology_assets.map(&:remote_id) }
let(:persisted_asset_ids) {
biology_assets.select(&:persisted?).map(&:remote_id)
}
let(:new_asset_ids) {
biology_assets.select(&:new_record?).map(&:remote_id)
}
they("are partially new, partially existing") do they("are partially new, partially existing") do
pending("Currently, pets must be saved before assets are assigned.") expect(persisted_asset_ids).to contain_exactly(10083, 11613)
fail # TODO: Write this test once we have the ability to see it pass! expect(new_asset_ids).to contain_exactly(10448, 10451)
end end
they("match the expected IDs") do they("match the expected IDs") do
expect(asset_ids).to contain_exactly(10083, 11613, 10448, 10451) expect(asset_ids).to contain_exactly(10083, 11613, 10448, 10451)
@ -208,17 +203,10 @@ RSpec.describe Pet, type: :model do
it("is a Striped Blumaroo") { expect(pet.pet_type.human_name).to eq "Striped Blumaroo" } it("is a Striped Blumaroo") { expect(pet.pet_type.human_name).to eq "Striped Blumaroo" }
describe "its biology assets" do describe "its biology assets" do
# TODO: I wish biology assets were set up before saving.
# Once we change this, we can un-mark some tests as pending.
before { pet.save! }
subject(:biology_assets) { pet.pet_state.swf_assets } subject(:biology_assets) { pet.pet_state.swf_assets }
let(:asset_ids) { biology_assets.map(&:remote_id) } let(:asset_ids) { biology_assets.map(&:remote_id) }
they("are all new") do they("are all new") { should all be_new_record }
pending("Currently, pets must be saved before assets are assigned.")
should all be_new_record
end
they("match the expected IDs") do they("match the expected IDs") do
expect(asset_ids).to contain_exactly(331, 332, 333, 23760, 23411) expect(asset_ids).to contain_exactly(331, 332, 333, 23760, 23411)
end end