OpenNeo/impress
OpenNeo/impress
1
0
Fork 1
Code Pull requests Activity

Oops, fix layout for error when item preview fails to load

Browse source 
Oh right, I need the error indicator to be part of a container that
also contains the outfit viewer, to appear below it!

I was motivated because I realized I forgot the Customize More button
so now I'm building it lol
This commit is contained in:
Emi Matchu 2024-09-06 16:24:58 -07:00
parent 5131ba40d8
commit 3a18820d05
2 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
app/assets/stylesheets/items/_show.sass
View file

@ -38,6 +38,9 @@ body.items-show
height: 16px height: 16px
width: 16px width: 16px
.preview-area
margin: 0 auto
outfit-viewer outfit-viewer
display: block display: block
position: relative position: relative
@ -46,7 +49,6 @@ body.items-show
border: 1px solid $module-border-color border: 1px solid $module-border-color
border-radius: 1em border-radius: 1em
overflow: hidden overflow: hidden
margin: 0 auto
// There's no useful text in here, but double-clicking the play/pause // There's no useful text in here, but double-clicking the play/pause
// button can cause a weird selection state. Disable text selection. // button can cause a weird selection state. Disable text selection.
@ -336,10 +338,11 @@ body.items-show
grid-template-areas: "viewer faces" "picker meta" grid-template-areas: "viewer faces" "picker meta"
gap: .5em gap: .5em
outfit-viewer .preview-area
grid-area: viewer grid-area: viewer
width: 350px outfit-viewer
height: 350px width: 350px
height: 350px
species-color-picker species-color-picker
grid-area: picker grid-area: picker

7
app/views/items/show.html.haml
View file

@ -15,9 +15,10 @@
sorry! sorry!
= turbo_frame_tag "item-preview" do = turbo_frame_tag "item-preview" do
= render partial: "outfit_viewer", locals: {outfit: @preview_outfit} .preview-area
.error-indicator = render partial: "outfit_viewer", locals: {outfit: @preview_outfit}
💥 We couldn't load all of this outfit. Try again? .error-indicator
💥 We couldn't load all of this outfit. Try again?
%species-color-picker %species-color-picker
= form_for item_path(@item), method: :get, data: {"is-valid": @preview_error.nil?} do |f| = form_for item_path(@item), method: :get, data: {"is-valid": @preview_error.nil?} do |f|