For biology assets, make clearer the weirdness with saving first

This commit is contained in:
Emi Matchu 2024-10-25 13:03:23 -07:00
parent 8a38ce90dc
commit 30ada0b7e1

View file

@ -32,18 +32,21 @@ RSpec.describe Pet, type: :model do
it("is saved when saving the pet") { pet.save!; should be_persisted } it("is saved when saving the pet") { pet.save!; should be_persisted }
describe "its biology assets" do describe "its biology assets" do
# TODO: I wish biology assets were set up before saving.
# Once we change this, we can un-mark some tests as pending.
before { pet.save! }
subject(:biology_assets) { pet_state.swf_assets } subject(:biology_assets) { pet_state.swf_assets }
let(:asset_ids) { biology_assets.map(&:remote_id) } let(:asset_ids) { biology_assets.map(&:remote_id) }
it("are all new") { should all be_new_record } it("are all new") do
pending("Currently, pets must be saved before assets are assigned.")
should all be_new_record
end
it("match the expected IDs") do it("match the expected IDs") do
pet.save! # TODO: I wish this were set up before saving.
expect(asset_ids).to contain_exactly(10083, 11613, 14187, 14189) expect(asset_ids).to contain_exactly(10083, 11613, 14187, 14189)
end end
it("have the expected asset metadata") do it("have the expected asset metadata") do
pet.save! # TODO: I wish this were set up before saving.
expect(pet_state.swf_assets).to contain_exactly( expect(pet_state.swf_assets).to contain_exactly(
a_record_matching( a_record_matching(
type: "biology", type: "biology",
@ -116,13 +119,18 @@ RSpec.describe Pet, type: :model do
it("is a Striped Blumaroo") { expect(pet.pet_type.human_name).to eq "Striped Blumaroo" } it("is a Striped Blumaroo") { expect(pet.pet_type.human_name).to eq "Striped Blumaroo" }
describe "its biology assets" do describe "its biology assets" do
# TODO: I wish biology assets were set up before saving.
# Once we change this, we can un-mark some tests as pending.
before { pet.save! }
subject(:biology_assets) { pet.pet_state.swf_assets } subject(:biology_assets) { pet.pet_state.swf_assets }
let(:asset_ids) { biology_assets.map(&:remote_id) } let(:asset_ids) { biology_assets.map(&:remote_id) }
it("are all new") { should all be_new_record } it("are all new") do
pending("Currently, pets must be saved before assets are assigned.")
should all be_new_record
end
it("match the expected IDs") do it("match the expected IDs") do
pet.save! # TODO: I wish this were set up before saving.
expect(asset_ids).to contain_exactly(331, 332, 333, 23760, 23411) expect(asset_ids).to contain_exactly(331, 332, 333, 23760, 23411)
end end
end end