OpenNeo/impress
OpenNeo/impress
1
0
Fork 1
Code Pull requests Activity

Fix silly variable scoping issue in item spec

Browse source 
Oh right, `@remote_id` is an instance variable so we can auto-increment
it over time, but `url` is just a derived value, and can just be local!
Silly!
This commit is contained in:
Emi Matchu 2024-11-19 13:32:47 -08:00
parent 91851bc340
commit 21eaf7b266
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
spec/models/item_spec.rb
View file

@ -31,8 +31,8 @@ RSpec.describe Item do
def build_item_asset(zone, body_id:)
@remote_id = (@remote_id || 0) + 1
@url = "https://images.neopets.example/#{@remote_id}.swf"
SwfAsset.new(type: "object", remote_id: @remote_id, url: @url,
url = "https://images.neopets.example/#{@remote_id}.swf"
SwfAsset.new(type: "object", remote_id: @remote_id, url:,
zones_restrict: "", zone:, body_id:)
end