OpenNeo/impress
OpenNeo/impress
1
0
Fork 1
Code Pull requests Activity

Stabilize IDs for outfit viewer component

Browse source
This commit is contained in:
Emi Matchu 2026-02-06 19:17:49 -08:00
parent f9b040c20b
commit 0691153101
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/views/application/_outfit_viewer.html.haml
View file

@ -1,4 +1,5 @@
- html_options = {} unless defined? html_options - html_options = {} unless defined? html_options
- viewer_id = html_options[:id] ||= "outfit-viewer-#{SecureRandom.hex(8)}"
= content_tag "outfit-viewer", **html_options do = content_tag "outfit-viewer", **html_options do
.loading-indicator= render partial: "hanger_spinner" .loading-indicator= render partial: "hanger_spinner"
@ -14,6 +15,7 @@
- outfit.visible_layers.each do |swf_asset| - outfit.visible_layers.each do |swf_asset|
%outfit-layer{ %outfit-layer{
id: "#{viewer_id}-layer-#{swf_asset.id}",
data: { data: {
"asset-id": swf_asset.id, "asset-id": swf_asset.id,
"zone": swf_asset.zone.label, "zone": swf_asset.zone.label,

2
app/views/items/show.html.haml
View file

@ -16,7 +16,7 @@
= turbo_frame_tag "item-preview" do = turbo_frame_tag "item-preview" do
.preview-area .preview-area
= outfit_viewer @preview_outfit = outfit_viewer @preview_outfit, id: "item-preview-outfit-viewer"
.error-indicator .error-indicator
💥 We couldn't load all of this outfit. Try again? 💥 We couldn't load all of this outfit. Try again?
= link_to wardrobe_path(params: @preview_outfit.wardrobe_params), = link_to wardrobe_path(params: @preview_outfit.wardrobe_params),