OpenNeo/impress
OpenNeo/impress
1
0
Fork 1
Code Pull requests Activity
impress/app/assets/stylesheets/swf_assets/show.css

13 lines
299 B
CSS
Raw Normal View History

swf_assets/show action to embed a canvas movie in a sandboxed iframe Not using this on the item page preview yet, but we will! I like this approach over e.g. a web component specifically for the sandboxing: while I don't exactly *distrust* JS that we're loading from Neopets.com, I don't like the idea of *any* part of the site that executes arbitrary JS unsafely at runtime, even if we theoretically trust where it theoretically came from. I don't want any failure upstream to have effects on us! I copied basically all of the JS from a related project `impress-media-server` that I had spun up at one point, to investigate similar embed techniques. Easy peasy drop-in-squeezy!
2024-07-03 19:50:41 -07:00
#asset-canvas,
Fix styling for embed page for image-only SWF assets This doesn't actually really matter, because this doesn't actually get used in the app right now? But I figure, hey it's not hard to maintain, let's just do it for consistency!
2024-07-06 12:49:25 -07:00
#asset-image,
swf_assets/show action to embed a canvas movie in a sandboxed iframe Not using this on the item page preview yet, but we will! I like this approach over e.g. a web component specifically for the sandboxing: while I don't exactly *distrust* JS that we're loading from Neopets.com, I don't like the idea of *any* part of the site that executes arbitrary JS unsafely at runtime, even if we theoretically trust where it theoretically came from. I don't want any failure upstream to have effects on us! I copied basically all of the JS from a related project `impress-media-server` that I had spun up at one point, to investigate similar embed techniques. Easy peasy drop-in-squeezy!
2024-07-03 19:50:41 -07:00
#fallback {
position: absolute;
left: 0;
top: 0;
Fix bug precompiling a CSS file that contains a `min()` expression When I run `bin/deploy:precompile` on the previous version, I get an error from libsass that `vw` and `vh` are incompatible units. I don't get this error in development, only when compiling for production. My inference is: 1. For the production build, Sass is trying to preprocess even non-SASS files, maybe to help minify them? 2. In Sass, their `min()` existed before CSS's `min()`, so it's treating it Like That, and returning a reasonable-in-some-cases-but- not-here error that `min(100vw, 100vh)` can't be *precomputed*. Anyway, wrapping it in `calc()` isn't a *problem*, and helps the Sass compiler not try to precompute it, so. Okay! https://github.com/sass/node-sass/issues/2815#issuecomment-575926329
2024-09-06 11:00:49 -07:00
/* HACK: `calc` isn't needed, but works around a bug in our asset pipeline,
* where libsass is trying to preprocess it. (We're not SASS tho?) */
width: calc(min(100vw, 100vh));
height: calc(min(100vw, 100vh));
swf_assets/show action to embed a canvas movie in a sandboxed iframe Not using this on the item page preview yet, but we will! I like this approach over e.g. a web component specifically for the sandboxing: while I don't exactly *distrust* JS that we're loading from Neopets.com, I don't like the idea of *any* part of the site that executes arbitrary JS unsafely at runtime, even if we theoretically trust where it theoretically came from. I don't want any failure upstream to have effects on us! I copied basically all of the JS from a related project `impress-media-server` that I had spun up at one point, to investigate similar embed techniques. Easy peasy drop-in-squeezy!
2024-07-03 19:50:41 -07:00
}
Copy permalink