Matchu
e5551a6847
Oops, my cute API idea for `speciesPickerProps` breaks `React.memo`, of course! We could fix this by having the caller memoize the `speciesPickerProps` object, but that's too unusual and error-prone. We could also fix this by writing a custom function for `React.memo` to determine whether props match, but that seems like overkill when there's only one actual prop we're using here in practice. So yeah, I've updated `SpeciesColorPicker` to just accept `speciesTestId` and `colorTestId` props instead! Note that actually this component _is_ still re-rendering too often, because of a Chakra bug I just discovered and reported! So this change won't immediately improve performance, but it should stop re-rendering too often once we _also_ upgrade Chakra after this bug is fixed. https://github.com/chakra-ui/chakra-ui/issues/4080 |
||
---|---|---|
.. | ||
support | ||
index.js | ||
Item.js | ||
ItemsAndSearchPanels.js | ||
ItemsPanel.js | ||
OutfitControls.js | ||
OutfitKnownGlitchesBadge.js | ||
PosePicker.js | ||
SearchPanel.js | ||
SearchToolbar.js | ||
useOutfitSaving.js | ||
useOutfitState.js | ||
WardrobeDevHacks.js | ||
WardrobePageLayout.js | ||
WardrobePreviewAndControls.js |