Add altStyleId to PetAppearance type and resolvers #2

Open
dice wants to merge 2 commits from dice/impress-2020:add-altStyleId into main
First-time contributor
No description provided.
matchu left a comment

Makes sense to me overall! I have a few questions about details. I also imagine, if we were being real serious, we'd want to expand this into a whole AltStyle GraphQL type… but I'm also comfy just doing whatever.

Also though, I'm curious what your use case is, and if I can address it more directly for ya. I know I put you through all this GraphQL business back when it all popped off, and I wonder if it might be good to keep simplifying our way off of it and into endpoints that just do what you need.

Makes sense to me overall! I have a few questions about details. I also imagine, if we were being real serious, we'd want to expand this into a whole `AltStyle` GraphQL type… but I'm also comfy just doing whatever. Also though, I'm curious what your use case is, and if I can address it more directly for ya. I know I put you through all this GraphQL business back when it all popped off, and I wonder if it might be good to keep simplifying our way off of it and into endpoints that just do what you need.
@ -57,0 +81,4 @@
if (altColorPetState) {
return { id: altColorPetState.id, altStyleId, altColorId };
}
}
Owner

I don't really follow what's going on in this block. In what cases would the alt color connect to the pet state? My understanding is they're totally disconnected from one another. (That's how we architected it on our end, anyway.)

I don't really follow what's going on in this block. In what cases would the alt color connect to the pet state? My understanding is they're totally disconnected from one another. (That's how we architected it on our end, anyway.)
@ -273,6 +285,7 @@ const resolvers = {
},
PetAppearance: {
altColorId: ({ altColorId }) => (altColorId),
Owner

I suppose we should either have this for both altStyleId and altColorId, or for neither. (I think maybe if we omit the resolvers it just does this exact operation by default? I'll check that before merging.)

I suppose we should either have this for both `altStyleId` and `altColorId`, or for neither. (I think maybe if we omit the resolvers it just does this exact operation by default? I'll check that before merging.)
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'add-altStyleId:dice-add-altStyleId'
git switch 'dice-add-altStyleId'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'main'
git merge --no-ff 'dice-add-altStyleId'
git switch 'dice-add-altStyleId'
git rebase 'main'
git switch 'main'
git merge --ff-only 'dice-add-altStyleId'
git switch 'dice-add-altStyleId'
git rebase 'main'
git switch 'main'
git merge --no-ff 'dice-add-altStyleId'
git switch 'main'
git merge --squash 'dice-add-altStyleId'
git switch 'main'
git merge --ff-only 'dice-add-altStyleId'
git switch 'main'
git merge 'dice-add-altStyleId'
git push origin 'main'
Sign in to join this conversation.
No reviewers
No labels
No milestone
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
OpenNeo/impress-2020!2
No description provided.