From f64b882de1ba2307d34d42b4c6d7c2921fef06b1 Mon Sep 17 00:00:00 2001
From: Matchu <matchu1993@gmail.com>
Date: Tue, 1 Sep 2020 03:53:24 -0700
Subject: [PATCH] hide unnecessary zone groups

This was bothering me, I'm surprised and pleased by how easy it seems it was to fix? :)

The strategy is just, look for groups that are provably redundant, and filter them out.

I hope it's correct! It's definitely cozier. Kyrii Mage items are good tests, they have a lot of interesting zones!
---
 src/app/WardrobePage/useOutfitState.js | 34 ++++++++++++++++++++++++--
 1 file changed, 32 insertions(+), 2 deletions(-)

diff --git a/src/app/WardrobePage/useOutfitState.js b/src/app/WardrobePage/useOutfitState.js
index f566a10..0ce525e 100644
--- a/src/app/WardrobePage/useOutfitState.js
+++ b/src/app/WardrobePage/useOutfitState.js
@@ -329,15 +329,45 @@ function getZonesAndItems(itemsById, wornItemIds, closetedItemIds) {
     }
   }
 
-  const zonesAndItems = Array.from(itemsByZoneLabel.entries()).map(
+  let zonesAndItems = Array.from(itemsByZoneLabel.entries()).map(
     ([zoneLabel, items]) => ({
       zoneLabel: zoneLabel,
       items: [...items].sort((a, b) => a.name.localeCompare(b.name)),
     })
   );
-
   zonesAndItems.sort((a, b) => a.zoneLabel.localeCompare(b.zoneLabel));
 
+  // As one last step, try to remove zone groups that aren't helpful.
+  const groupsWithConflicts = zonesAndItems.filter(
+    ({ items }) => items.length > 1
+  );
+  const itemIdsWithConflicts = new Set(
+    groupsWithConflicts
+      .map(({ items }) => items)
+      .flat()
+      .map((item) => item.id)
+  );
+  const itemIdsWeHaveSeen = new Set();
+  zonesAndItems = zonesAndItems.filter(({ items }) => {
+    // We need all groups with more than one item. If there's only one, we get
+    // to think harder :)
+    if (items.length > 1) {
+      items.forEach((item) => itemIdsWeHaveSeen.add(item.id));
+      return true;
+    }
+
+    const item = items[0];
+
+    // Has the item been seen a group we kept, or an upcoming group with
+    // multiple conflicting items? If so, skip this group. If not, keep it.
+    if (itemIdsWeHaveSeen.has(item.id) || itemIdsWithConflicts.has(item.id)) {
+      return false;
+    } else {
+      itemIdsWeHaveSeen.add(item.id);
+      return true;
+    }
+  });
+
   return zonesAndItems;
 }