OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

Fix bug where we weren't recognizing new SVGs

Browse source 
So, we've been behind the latest conversion data for a while anyway, because I don't run the sync very often. But I ran the sync today and noticed that the newly converted SVGs weren't showing up in DTI!

This is because TNT changed the asset manifest structure they use for SVG-only assets. Now, we support both!

To test, I checked the Blue Acara (old-style SVG manifest), the Blue Chia (new-style SVG manifest), and the Floating Negg Faerie Doll (animated clip).
This commit is contained in:
Emi Matchu 2021-01-20 10:43:41 -08:00
parent 275d1d62ab
commit f40ccf0b21
1 changed files with 16 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/server/types/AppearanceLayer.js
View file

@ -153,16 +153,28 @@ const resolvers = {
} }
const asset = manifest.assets[0]; const asset = manifest.assets[0];
if (asset.format !== "vector") { if (asset.format !== "vector" && asset.format !== "lod") {
return null; return null;
} }
if (asset.assetData.length !== 1) { // In the `lod` case, if there's a JS asset, then don't treat this as an
// SVG asset at all. (There might be an SVG in the asset list anyway
// sometimes I think, for the animation, but ignore it if so!)
const jsAssetDatum = asset.assetData.find((ad) =>
ad.path.endsWith(".js")
);
if (jsAssetDatum) {
return null; return null;
} }
const assetDatum = asset.assetData[0]; const svgAssetDatum = asset.assetData.find((ad) =>
const url = new URL(assetDatum.path, "http://images.neopets.com"); ad.path.endsWith(".svg")
);
if (!svgAssetDatum) {
return null;
}
const url = new URL(svgAssetDatum.path, "http://images.neopets.com");
return url.toString(); return url.toString();
}, },
canvasMovieLibraryUrl: async ({ id }, _, { db, swfAssetLoader }) => { canvasMovieLibraryUrl: async ({ id }, _, { db, swfAssetLoader }) => {