OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

Fix bug unwearing/removing search results

Browse source 
Oops, our "items to reconsider" feature was preventing unwearing/removing items you're already wearing!

This feature helps you try stuff in Search, without disrupting your outfit. e.g. if you try on a new Background, then change your mind and unwear it, then we reapply whatever old Background you had on the outfit before.

But this made it impossible to remove your _current_ background from the search page if you went back and searched for it again, because we would remove it and then reconsider and reapply it 😅

Now we, um, stop that!
This commit is contained in:
Emi Matchu 2021-04-26 07:21:47 -07:00
parent 6517087568
commit f3173db7b3
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/app/WardrobePage/useOutfitState.js
View file

@ -248,6 +248,7 @@ function useOutfitState() {
}
const outfitStateReducer = (apolloClient) => (baseState, action) => {
console.log("[Outfit state] Action:", action);
switch (action.type) {
case "rename":
return produce(baseState, (state) => {
@ -304,7 +305,12 @@ const outfitStateReducer = (apolloClient) => (baseState, action) => {
wornItemIds.delete(itemId);
closetedItemIds.add(itemId);
reconsiderItems(itemIdsToReconsider, state, apolloClient);
reconsiderItems(
// Don't include the unworn item in items to reconsider!
itemIdsToReconsider.filter((x) => x !== itemId),
state,
apolloClient
);
});
case "removeItem":
return produce(baseState, (state) => {
@ -315,7 +321,12 @@ const outfitStateReducer = (apolloClient) => (baseState, action) => {
wornItemIds.delete(itemId);
closetedItemIds.delete(itemId);
reconsiderItems(itemIdsToReconsider, state, apolloClient);
reconsiderItems(
// Don't include the removed item in items to reconsider!
itemIdsToReconsider.filter((x) => x !== itemId),
state,
apolloClient
);
});
case "setPose":
return produce(baseState, (state) => {