OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

Update asset manifests after 3 days of staleness

Browse source
This commit is contained in:
Emi Matchu 2021-04-26 06:40:05 -07:00
parent 6918b3cefa
commit d98a533dce
1 changed files with 29 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
src/server/types/AppearanceLayer.js
View file

@ -362,6 +362,15 @@ function convertLayerTypeToSwfAssetType(layerType) {
} }
} }
// We'll keep manifests in the db for up to 3 days! I'm not sure how well this
// will perform in practice re hit ratio... keep an eye on it! But this will
// keep us up-to-date for changes, esp during this HTML5 conversion period,
// while avoiding _too_ much additional latency. (The main risk here is that
// cache misses add a SQL UPDATE to the execution path, so cache misses are
// _worse_ than a no-cache strategy...) We could also consider a regular cron
// re-sync of all of them!
const MAX_MANIFEST_AGE_IN_MS = 3 * 24 * 60 * 60 * 1000;
/** /**
* loadAndCacheAssetDataFromManifest loads and caches the manifest (if not * loadAndCacheAssetDataFromManifest loads and caches the manifest (if not
* already cached on the layer from the database), and then accesses some * already cached on the layer from the database), and then accesses some
@ -384,17 +393,23 @@ async function loadAndCacheAssetDataFromManifest(db, layer) {
manifest = null; manifest = null;
} }
// When the manifest is specifically null, that means we don't know if const manifestAgeInMs = layer.manifestCachedAt
// it exists yet. Load it to find out! ? new Date() - new Date(layer.manifestCachedAt)
if (manifest === null) { : Infinity;
// If we don't have a recent copy of the manifest (none at all, or an expired
// one), load it!
if (manifest === null || manifestAgeInMs > MAX_MANIFEST_AGE_IN_MS) {
console.info(
`[Layer ${layer.id}] Updating manifest cache, ` +
`last updated ${manifestAgeInMs}ms ago: ${layer.manifestCachedAt}`
);
manifest = await loadAndCacheAssetManifest(db, layer); manifest = await loadAndCacheAssetManifest(db, layer);
} }
if (!manifest) { // If we have an empty copy of the manifest ("" means 404 etc, or it can be
return { format: null, assetUrls: [] }; // actually empty), return empty data.
} if (manifest === "" && manifest.assets.length !== 1) {
if (manifest.assets.length !== 1) {
return { format: null, assetUrls: [] }; return { format: null, assetUrls: [] };
} }
@ -463,10 +478,12 @@ async function loadAndCacheAssetManifest(db, layer) {
return manifest; return manifest;
} }
const [ const [result] = await db.execute(
result, `
] = await db.execute( UPDATE swf_assets
`UPDATE swf_assets SET manifest = ? WHERE id = ? LIMIT 1;`, SET manifest = ?, manifest_cached_at = CURRENT_TIMESTAMP()
WHERE id = ? LIMIT 1;
`,
[manifestJson, layer.id] [manifestJson, layer.id]
); );
if (result.affectedRows !== 1) { if (result.affectedRows !== 1) {