OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

Show placeholder when item description is blank

Browse source 
I'm not sure real item data "should" ever do this? Our "Written Word Shower" had a blank description, but I think that was an error on our end.

Anyway, it's clearer than showing infinite loading, so!
This commit is contained in:
Emi Matchu 2021-06-17 21:31:04 -07:00
parent 6ae22d171b
commit d386ccfad8
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/app/ItemPage.js
View file

@ -118,7 +118,11 @@ function ItemPageDescription({ description, isEmbedded }) {
return ( return (
<Box width="100%" alignSelf="flex-start"> <Box width="100%" alignSelf="flex-start">
{description || ( {description ? (
description
) : description === "" ? (
<i>(This item has no description.)</i>
) : (
<Box <Box
maxWidth="40em" maxWidth="40em"
minHeight={numDescriptionLines * 1.5 + "em"} minHeight={numDescriptionLines * 1.5 + "em"}