From ba8e4d8aa744c77b7e3b158f41b6dc364d69a339 Mon Sep 17 00:00:00 2001 From: Matchu Date: Sun, 8 Aug 2021 00:23:57 -0700 Subject: [PATCH] Trickier disabling honeycomb instrumentation Hm, okay, so the documented way to not instrument anything doesn't actually stop them from patching Module._load. But this undocumented option sure does! So, woo, let's try it! lol --- api/allWakaValues.js | 2 +- api/assetImage.js | 2 +- api/graphql.js | 2 +- api/outfitImage.js | 2 +- api/outfitPageSSR.js | 2 +- api/sendFeedback.js | 2 +- api/uploadLayerImage.js | 2 +- api/validPetPoses.js | 2 +- scripts/build-cached-data.js | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/api/allWakaValues.js b/api/allWakaValues.js index ec97e6e..ecf9f21 100644 --- a/api/allWakaValues.js +++ b/api/allWakaValues.js @@ -5,7 +5,7 @@ const beeline = require("honeycomb-beeline")({ ? "Dress to Impress (2020)" : "Dress to Impress (2020, dev)", serviceName: "impress-2020-gql-server", - enabledInstrumentations: [], + disableInstrumentationOnLoad: true, }); import fetch from "node-fetch"; diff --git a/api/assetImage.js b/api/assetImage.js index 4a2e1bc..27cf1a8 100644 --- a/api/assetImage.js +++ b/api/assetImage.js @@ -15,7 +15,7 @@ const beeline = require("honeycomb-beeline")({ ? "Dress to Impress (2020)" : "Dress to Impress (2020, dev)", serviceName: "impress-2020-gql-server", - enabledInstrumentations: [], + disableInstrumentationOnLoad: true, }); const { chromium } = require("playwright"); diff --git a/api/graphql.js b/api/graphql.js index 08d9baa..cd2e2bf 100644 --- a/api/graphql.js +++ b/api/graphql.js @@ -5,7 +5,7 @@ const beeline = require("honeycomb-beeline")({ ? "Dress to Impress (2020)" : "Dress to Impress (2020, dev)", serviceName: "impress-2020-gql-server", - enabledInstrumentations: [], + disableInstrumentationOnLoad: true, samplerHook, }); diff --git a/api/outfitImage.js b/api/outfitImage.js index e68e790..f44fd9a 100644 --- a/api/outfitImage.js +++ b/api/outfitImage.js @@ -31,7 +31,7 @@ const beeline = require("honeycomb-beeline")({ ? "Dress to Impress (2020)" : "Dress to Impress (2020, dev)", serviceName: "impress-2020-gql-server", - enabledInstrumentations: [], + disableInstrumentationOnLoad: true, sampleRate: 10, }); diff --git a/api/outfitPageSSR.js b/api/outfitPageSSR.js index b0808b7..861370d 100644 --- a/api/outfitPageSSR.js +++ b/api/outfitPageSSR.js @@ -19,7 +19,7 @@ const beeline = require("honeycomb-beeline")({ ? "Dress to Impress (2020)" : "Dress to Impress (2020, dev)", serviceName: "impress-2020-gql-server", - enabledInstrumentations: [], + disableInstrumentationOnLoad: true, }); import escapeHtml from "escape-html"; diff --git a/api/sendFeedback.js b/api/sendFeedback.js index 239e2e3..b48dae1 100644 --- a/api/sendFeedback.js +++ b/api/sendFeedback.js @@ -5,7 +5,7 @@ const beeline = require("honeycomb-beeline")({ ? "Dress to Impress (2020)" : "Dress to Impress (2020, dev)", serviceName: "impress-2020-gql-server", - enabledInstrumentations: [], + disableInstrumentationOnLoad: true, }); import sendgridMail from "@sendgrid/mail"; diff --git a/api/uploadLayerImage.js b/api/uploadLayerImage.js index 997d93e..01669f6 100644 --- a/api/uploadLayerImage.js +++ b/api/uploadLayerImage.js @@ -5,7 +5,7 @@ const beeline = require("honeycomb-beeline")({ ? "Dress to Impress (2020)" : "Dress to Impress (2020, dev)", serviceName: "impress-2020-gql-server", - enabledInstrumentations: [], + disableInstrumentationOnLoad: true, }); const AWS = require("aws-sdk"); const Jimp = require("jimp"); diff --git a/api/validPetPoses.js b/api/validPetPoses.js index 89fe654..be479b4 100644 --- a/api/validPetPoses.js +++ b/api/validPetPoses.js @@ -5,7 +5,7 @@ const beeline = require("honeycomb-beeline")({ ? "Dress to Impress (2020)" : "Dress to Impress (2020, dev)", serviceName: "impress-2020-gql-server", - enabledInstrumentations: [], + disableInstrumentationOnLoad: true, }); import connectToDb from "../src/server/db"; import { getPoseFromPetState, normalizeRow } from "../src/server/util"; diff --git a/scripts/build-cached-data.js b/scripts/build-cached-data.js index f72f4f9..8200139 100644 --- a/scripts/build-cached-data.js +++ b/scripts/build-cached-data.js @@ -7,7 +7,7 @@ require("honeycomb-beeline")({ ? "Dress to Impress (2020)" : "Dress to Impress (2020, dev)", serviceName: "impress-2020-build-process", - enabledInstrumentations: [], + disableInstrumentationOnLoad: true, }); const fs = require("fs").promises; const path = require("path");