OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

Whoops, fix outfitImage caching bug

Browse source 
I was accidentally serving images _without_ `updatedAt` with the long-term cache headers, but only in prod, not in dev

I think this is probably because I made a mistake in my Vercel route config, by including an `$updatedAt` parameter that doesn't actually exist in this case.

I'm guessing the Vercel dev server has different behavior for my mistake than the prod server. I'm guessing the dev server makes it an empty string, and the prod server makes it the literal string `$updatedAt`. Oops!

I hope this fixes it!
This commit is contained in:
Emi Matchu 2021-05-27 17:29:06 -07:00
parent e608844171
commit a5c3108a90
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
vercel.json
View file

@ -2,7 +2,7 @@
"routes": [ "routes": [
{ {
"src": "/outfits/(?<id>[^/]+)/(?<size>150|300|600).png", "src": "/outfits/(?<id>[^/]+)/(?<size>150|300|600).png",
"dest": "/api/outfitImage.js?size=$size&id=$id&updatedAt=$updatedAt" "dest": "/api/outfitImage.js?size=$size&id=$id"
}, },
{ {
"src": "/outfits/(?<id>[^/]+)/v/(?<updatedAt>[^/]+)/(?<size>150|300|600).png", "src": "/outfits/(?<id>[^/]+)/v/(?<updatedAt>[^/]+)/(?<size>150|300|600).png",