OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

Fix crash on user lists page from orphaned hangers

Browse source 
If you delete a closet list without deleting the items in it, it'll dump them into your default own/want lists. This isn't necessarily the behavior we really want, but oh well, that's the truth right now!

The GraphQL endpoint was assuming that all hanger `list_id` values were valid, oops! Now, we ignore list IDs that don't match a list.
This commit is contained in:
Emi Matchu 2023-10-24 14:48:55 -07:00
parent 53deee85dd
commit a2594d1797
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/server/types/User.js
View file

@ -238,7 +238,7 @@ const resolvers = {
const defaultListOwnedHangers = []; const defaultListOwnedHangers = [];
const defaultListWantedHangers = []; const defaultListWantedHangers = [];
for (const hanger of allClosetHangers) { for (const hanger of allClosetHangers) {
if (hanger.listId) { if (hanger.listId && hangersByList.has(hanger.listId)) {
hangersByList.get(hanger.listId).push(hanger); hangersByList.get(hanger.listId).push(hanger);
} else if (hanger.owned) { } else if (hanger.owned) {
defaultListOwnedHangers.push(hanger); defaultListOwnedHangers.push(hanger);