fix item skeletons for new spacing

This commit is contained in:
Matt Dunn-Rankin 2020-04-25 03:05:26 -07:00
parent 1b47b4b23f
commit 9c9a2662a0
3 changed files with 4 additions and 5 deletions

View file

@ -1,5 +1,4 @@
* Use accessible click targets for item lists! Honestly, can they be checkboxes? * Use accessible click targets for item lists! Honestly, can they be checkboxes?
* Update skeletons for ItemList and ItemsPanel
* Use react-virtualized instead of our own scroller, but we need total count known, and we need another solution for the CSS transitions in the outfit case * Use react-virtualized instead of our own scroller, but we need total count known, and we need another solution for the CSS transitions in the outfit case
* Restore good download behavior: use crossOrigin for everything, and remove cache-buster in the URL we use for canvas * Restore good download behavior: use crossOrigin for everything, and remove cache-buster in the URL we use for canvas
* Undo the local linking we did for @chakra-ui/core, react, and react-dom on Matchu's machine 😅 * Undo the local linking we did for @chakra-ui/core, react, and react-dom on Matchu's machine 😅

View file

@ -42,13 +42,13 @@ function ItemList({ items, outfitState, dispatchToOutfit }) {
function ItemListSkeleton({ count }) { function ItemListSkeleton({ count }) {
return ( return (
<Stack spacing="3"> <Flex direction="column">
{Array.from({ length: count }).map((_, i) => ( {Array.from({ length: count }).map((_, i) => (
<Box key={i}> <Box key={i} mb="2" mt="2">
<ItemSkeleton /> <ItemSkeleton />
</Box> </Box>
))} ))}
</Stack> </Flex>
); );
} }

View file

@ -28,7 +28,7 @@ function ItemsPanel({ outfitState, loading, dispatchToOutfit }) {
<Flex direction="column"> <Flex direction="column">
{loading && {loading &&
[1, 2, 3].map((i) => ( [1, 2, 3].map((i) => (
<Box key={i}> <Box key={i} mb="10">
<Delay> <Delay>
<Skeleton height="2.3rem" width="12rem" /> <Skeleton height="2.3rem" width="12rem" />
<ItemListSkeleton count={3} /> <ItemListSkeleton count={3} />