OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

Check for new outfit saved indicator in Cypress

Browse source
This commit is contained in:
Emi Matchu 2021-04-22 02:44:45 -07:00
parent 99e0fdbf59
commit 8b5ba60ea8
6 changed files with 19 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
cypress/integration/WardrobePage/Outfit saving.spec.js
View file

@ -15,10 +15,8 @@ describe("WardrobePage: Outfit saving", () => {
// Wait for the outfit to stop saving, and check that it redirected and // Wait for the outfit to stop saving, and check that it redirected and
// still shows the correct outfit preview and name. // still shows the correct outfit preview and name.
cy.location("pathname", { timeout: 12000 }).should( page.getOutfitIsSavedIndicator({ timeout: 12000 }).should("exist");
"match", cy.location("pathname").should("match", /^\/outfits\/[0-9]+$/);
/^\/outfits\/[0-9]+$/
);
page.getOutfitName().should("have.text", outfitName); page.getOutfitName().should("have.text", outfitName);
page.getOutfitPreview().toMatchImageSnapshot(); page.getOutfitPreview().toMatchImageSnapshot();
}); });
@ -39,10 +37,8 @@ describe("WardrobePage: Outfit saving", () => {
// Wait for the outfit to stop saving, and check that it redirected and // Wait for the outfit to stop saving, and check that it redirected and
// still shows the correct outfit preview and name. // still shows the correct outfit preview and name.
cy.location("pathname", { timeout: 12000 }).should( page.getOutfitIsSavedIndicator({ timeout: 12000 }).should("exist");
"match", cy.location("pathname").should("match", /^\/outfits\/[0-9]+$/);
/^\/outfits\/[0-9]+$/
);
page.getOutfitName().should("have.text", outfitName); page.getOutfitName().should("have.text", outfitName);
page.getOutfitPreview().toMatchImageSnapshot(); page.getOutfitPreview().toMatchImageSnapshot();
}); });

BIN
cypress/integration/WardrobePage/__image_snapshots__/WardrobePage Outfit saving Saves a Zafara Tourist with worn and closeted items #0.png
View file

Binary file not shown.
Side by side Swipe Overlay

Before

Width:  |  Height:  |  Size: 313 KiB

After

Width:  |  Height:  |  Size: 316 KiB

BIN
cypress/integration/WardrobePage/__image_snapshots__/WardrobePage Outfit saving Saves a basic outfit #0.png
View file

Binary file not shown.
Side by side

Before

Width:  |  Height:  |  Size: 52 KiB

BIN
cypress/integration/WardrobePage/__image_snapshots__/WardrobePage Outfit saving Saves a simple Blue Acara #0.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 50 KiB

28
cypress/integration/WardrobePage/page.js
View file

@ -1,14 +1,14 @@
export function getSpeciesSelect(options) { const withTestId = (testId) => (options) =>
return cy.get("[data-test-id=wardrobe-species-picker]", options); cy.get(`[data-test-id="${CSS.escape(testId)}"]`, options);
}
export function getColorSelect(options) { export const getSpeciesSelect = withTestId("wardrobe-species-picker");
return cy.get("[data-test-id=wardrobe-color-picker]", options); export const getColorSelect = withTestId("wardrobe-color-picker");
} export const getPosePickerButton = withTestId("wardrobe-pose-picker");
export const getOutfitName = withTestId("outfit-name");
export function getPosePickerButton(options) { export const getSaveOutfitButton = withTestId("wardrobe-save-outfit-button");
return cy.get("[data-test-id=wardrobe-pose-picker]", options); export const getOutfitIsSavedIndicator = withTestId(
} "wardrobe-outfit-is-saved-indicator"
);
export function getPosePickerOption(label, options) { export function getPosePickerOption(label, options) {
return cy.get(`input[aria-label="${CSS.escape(label)}"]`, options); return cy.get(`input[aria-label="${CSS.escape(label)}"]`, options);
@ -20,11 +20,3 @@ export function getOutfitPreview() {
timeout: 15000, timeout: 15000,
}); });
} }
export function getOutfitName(options) {
return cy.get("[data-test-id=outfit-name]", options);
}
export function getSaveOutfitButton(options) {
return cy.get("[data-test-id=wardrobe-save-outfit-button]", options);
}

6
src/app/WardrobePage/ItemsPanel.js
View file

@ -429,7 +429,11 @@ function OutfitSavingIndicator({ outfitState }) {
if (latestVersionIsSaved) { if (latestVersionIsSaved) {
return ( return (
<Flex align="center" fontSize="xs"> <Flex
align="center"
fontSize="xs"
data-test-id="wardrobe-outfit-is-saved-indicator"
>
<CheckIcon <CheckIcon
marginRight="1" marginRight="1"
// HACK: Not sure why my various centering things always feel wrong... // HACK: Not sure why my various centering things always feel wrong...