stop using javascript:void 0 as a placeholder

2020-05-19 18:30:54 -07:00 · 2020-05-19 18:30:54 -07:00 · 674107516c
commit 674107516c
parent 1237ed0bb2
1 changed files with 6 additions and 1 deletions
--- a/src/app/OutfitControls.js
+++ b/src/app/OutfitControls.js
@ -135,7 +135,12 @@ function DownloadButton({ outfitState }) {
          aria-label="Download"
          as="a"
          // eslint-disable-next-line no-script-url
-          href={downloadImageUrl || "javascript:void 0"}
+          href={downloadImageUrl || "#"}
+          onClick={(e) => {
+            if (!downloadImageUrl) {
+              e.preventDefault();
+            }
+          }}
          download={(outfitState.name || "Outfit") + ".png"}
          onMouseEnter={prepareDownload}
          onFocus={prepareDownload}