OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

stop using javascript:void 0 as a placeholder

Browse source
This commit is contained in:
Matt Dunn-Rankin 2020-05-19 18:30:54 -07:00
parent 1237ed0bb2
commit 674107516c
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/app/OutfitControls.js
View file

@ -135,7 +135,12 @@ function DownloadButton({ outfitState }) {
aria-label="Download" aria-label="Download"
as="a" as="a"
// eslint-disable-next-line no-script-url // eslint-disable-next-line no-script-url
href={downloadImageUrl || "javascript:void 0"} href={downloadImageUrl || "#"}
onClick={(e) => {
if (!downloadImageUrl) {
e.preventDefault();
}
}}
download={(outfitState.name || "Outfit") + ".png"} download={(outfitState.name || "Outfit") + ".png"}
onMouseEnter={prepareDownload} onMouseEnter={prepareDownload}
onFocus={prepareDownload} onFocus={prepareDownload}