OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

Oops, fix outfit page SSR title

Browse source 
Untitled outfits need a fallback, or else they show "null"!
This commit is contained in:
Emi Matchu 2021-06-15 22:49:29 -07:00
parent 5c5bdb11ff
commit 5a18a1d041
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
api/outfitPageSSR.js
View file

@ -58,6 +58,8 @@ async function handle(req, res) {
return sendHtml(res, initialHtml, 404); return sendHtml(res, initialHtml, 404);
} }
const outfitName = outfit.name || "Untitled outfit";
// Okay, now let's rewrite the HTML to include some outfit data! // Okay, now let's rewrite the HTML to include some outfit data!
// //
// WARNING!!! // WARNING!!!
@ -69,7 +71,7 @@ async function handle(req, res) {
// Add the outfit name to the title. // Add the outfit name to the title.
html = html.replace( html = html.replace(
/<title>(.*)<\/title>/, /<title>(.*)<\/title>/,
`<title>${escapeHtml(outfit.name)} | Dress to Impress</title>` `<title>${escapeHtml(outfitName)} | Dress to Impress</title>`
); );
// Add sharing meta tags just before the </head> tag. // Add sharing meta tags just before the </head> tag.
@ -85,7 +87,7 @@ async function handle(req, res) {
`/v/${encodeURIComponent(updatedAtTimestamp)}` + `/v/${encodeURIComponent(updatedAtTimestamp)}` +
`/600.png`; `/600.png`;
const metaTags = ` const metaTags = `
<meta property="og:title" content="${escapeHtml(outfit.name)}"> <meta property="og:title" content="${escapeHtml(outfitName)}">
<meta property="og:type" content="website"> <meta property="og:type" content="website">
<meta property="og:image" content="${escapeHtml(imageUrl)}"> <meta property="og:image" content="${escapeHtml(imageUrl)}">
<meta property="og:url" content="${escapeHtml(outfitUrl)}"> <meta property="og:url" content="${escapeHtml(outfitUrl)}">