OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

Add CORS headers to /api/assetImage

Browse source 
Sometimes main DTI gets this back as the image URL for a movie asset,
we need to be able to request it!
This commit is contained in:
Emi Matchu 2024-02-01 08:36:21 -08:00
parent f566012386
commit 4e1739cd16
1 changed files with 15 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
pages/api/assetImage.js
View file

@ -24,6 +24,8 @@ const beeline = require("honeycomb-beeline")({
const puppeteer = require("puppeteer"); const puppeteer = require("puppeteer");
const genericPool = require("generic-pool"); const genericPool = require("generic-pool");
const { applyCORSHeaders } = require("../../src/server/cors");
console.info(`Creating new browser instance`); console.info(`Creating new browser instance`);
const browserPromise = puppeteer.launch({ headless: true }); const browserPromise = puppeteer.launch({ headless: true });
@ -48,12 +50,20 @@ const PAGE_POOL = genericPool.createPool(
}, },
validate: (page) => page.browser().isConnected(), validate: (page) => page.browser().isConnected(),
}, },
{ min: 4, max: 4, testOnBorrow: true, acquireTimeoutMillis: 15000 } { min: 4, max: 4, testOnBorrow: true, acquireTimeoutMillis: 15000 },
); );
PAGE_POOL.on("factoryCreateError", (error) => console.error(error)); PAGE_POOL.on("factoryCreateError", (error) => console.error(error));
PAGE_POOL.on("factoryDestroyError", (error) => console.error(error)); PAGE_POOL.on("factoryDestroyError", (error) => console.error(error));
async function handle(req, res) { async function handle(req, res) {
// Apply CORS headers, to allow Classic DTI to request this.
// If this is an OPTIONS request asking for CORS info, return an empty
// response with just the CORS headers applied.
applyCORSHeaders(req, res);
if (req.method === "OPTIONS") {
return res.status(204).end();
}
const { libraryUrl, size } = req.query; const { libraryUrl, size } = req.query;
if (!libraryUrl) { if (!libraryUrl) {
return reject(res, "libraryUrl is required"); return reject(res, "libraryUrl is required");
@ -62,7 +72,7 @@ async function handle(req, res) {
if (!isNeopetsUrl(libraryUrl)) { if (!isNeopetsUrl(libraryUrl)) {
return reject( return reject(
res, res,
`libraryUrl must be an HTTPS Neopets URL, but was: ${libraryUrl}` `libraryUrl must be an HTTPS Neopets URL, but was: ${libraryUrl}`,
); );
} }
@ -97,7 +107,7 @@ async function loadAndScreenshotImage(libraryUrl, size) {
// NOTE: If we deploy to a host where localhost:3000 won't work, make this // NOTE: If we deploy to a host where localhost:3000 won't work, make this
// configurable with an env var, e.g. process.env.LOCAL_APP_HOST // configurable with an env var, e.g. process.env.LOCAL_APP_HOST
const assetImagePageUrl = new URL( const assetImagePageUrl = new URL(
"http://localhost:3000/internal/assetImage" "http://localhost:3000/internal/assetImage",
); );
assetImagePageUrl.search = new URLSearchParams({ assetImagePageUrl.search = new URLSearchParams({
libraryUrl, libraryUrl,
@ -139,7 +149,7 @@ async function loadAndScreenshotImage(libraryUrl, size) {
} else { } else {
throw new Error( throw new Error(
`Assertion error: Promise.any did not return an errorMessage or an imageBuffer: ` + `Assertion error: Promise.any did not return an errorMessage or an imageBuffer: ` +
`${JSON.stringify(Object.keys(firstResultFromPage))}` `${JSON.stringify(Object.keys(firstResultFromPage))}`,
); );
} }
} finally { } finally {
@ -206,7 +216,7 @@ Promise.any =
async function handleWithBeeline(req, res) { async function handleWithBeeline(req, res) {
beeline.withTrace( beeline.withTrace(
{ name: "api/assetImage", operation_name: "api/assetImage" }, { name: "api/assetImage", operation_name: "api/assetImage" },
() => handle(req, res) () => handle(req, res),
); );
} }