OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

Enable free color/species input on ItemPage

Browse source 
Previously, I kept this constrained to valid species/color pairs only, because we didn't have a great error state. But at this point, it feels worse to throw people out of the color they're looking at, and to make it harder for them to pick the color in the first place!
This commit is contained in:
Emi Matchu 2021-02-03 01:51:51 -08:00
parent 6a4be0390a
commit 4431c43663
1 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/app/ItemPage.js
View file

@ -690,11 +690,6 @@ function ItemPageOutfitPreview({ itemId }) {
speciesIsDisabled={isProbablySpeciesSpecific} speciesIsDisabled={isProbablySpeciesSpecific}
size="sm" size="sm"
showPlaceholders showPlaceholders
// This is just a UX affordance: while we could handle invalid states
// from a UI perspective, we figure that, if a pet preview is already
// visible and responsive to changes, it feels better to treat the
// changes as atomic and always-valid.
stateMustAlwaysBeValid
/> />
<Box flex="1 0 0" lineHeight="1"> <Box flex="1 0 0" lineHeight="1">
{isIncompatible && ( {isIncompatible && (