From 3ec0ae7557a81d31b8447b4e6e78b2d0cbc40b6a Mon Sep 17 00:00:00 2001 From: Matchu Date: Fri, 12 Nov 2021 22:08:06 -0800 Subject: [PATCH] Use localhost in /api/assetImage Just another VERCEL_URL removal! --- pages/api/assetImage.js | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/pages/api/assetImage.js b/pages/api/assetImage.js index 0c285ea..bc77c5e 100644 --- a/pages/api/assetImage.js +++ b/pages/api/assetImage.js @@ -24,14 +24,6 @@ const beeline = require("honeycomb-beeline")({ const playwright = require("playwright"); -// To render the image, we load the /internal/assetImage page in the web app, -// a simple page specifically designed for this API endpoint! -const ASSET_IMAGE_PAGE_BASE_URL = process.env.VERCEL_URL - ? `https://${process.env.VERCEL_URL}/internal/assetImage` - : process.env.NODE_ENV === "development" - ? "http://localhost:3000/internal/assetImage" - : "https://impress-2020.openneo.net/internal/assetImage"; - // We share one browser instance, but create a new independent "context" for // each request, as a security hedge. (The intent is for the user to request // very little from the browser, so it shouldn't matter, but it's just an extra @@ -84,7 +76,14 @@ async function handle(req, res) { } async function loadAndScreenshotImage(libraryUrl, size) { - const assetImagePageUrl = new URL(ASSET_IMAGE_PAGE_BASE_URL); + // To render the image, we load the /internal/assetImage page in the web app, + // a simple page specifically designed for this API endpoint! + // + // NOTE: If we deploy to a host where localhost:3000 won't work, make this + // configurable with an env var, e.g. process.env.LOCAL_APP_HOST + const assetImagePageUrl = new URL( + "http://localhost:3000/internal/assetImage" + ); assetImagePageUrl.search = new URLSearchParams({ libraryUrl, size,