From 3ce5e74b09f80e087d1a34d7d6a59ab1d4840195 Mon Sep 17 00:00:00 2001 From: Matchu Date: Tue, 27 Oct 2020 21:43:57 -0700 Subject: [PATCH] swap own badge and want badge --- src/app/UserItemsPage.js | 33 +++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/src/app/UserItemsPage.js b/src/app/UserItemsPage.js index 4e89285..e67a288 100644 --- a/src/app/UserItemsPage.js +++ b/src/app/UserItemsPage.js @@ -135,20 +135,11 @@ function UserItemsPage() { Neomail )} - {numYouOwnThisBadges > 0 && ( - - - {numYouOwnThisBadges > 1 - ? `${numYouOwnThisBadges} items you own` - : "1 item you own"} - - )} + {/* Usually I put "Own" before "Want", but this matches the natural + * order on the page: the _matches_ for things you want are things + * _this user_ owns, so they come first. I think it's also probably a + * more natural train of thought: you come to someone's list _wanting_ + * something, and _then_ thinking about what you can offer. */} {numYouWantThisBadges > 0 && ( )} + {numYouOwnThisBadges > 0 && ( + + + {numYouOwnThisBadges > 1 + ? `${numYouOwnThisBadges} items you own` + : "1 item you own"} + + )} {isCurrentUser ? "Items you own" : `Items ${data.user.username} owns`}