OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

Oops, fix a bug where incorrect login closed modal

Browse source 
Oh yeah, ok, we don't actually want to evict `currentUser` from the Apollo cache on *any* login mutation. That's both inefficient, and puts our navbar in a loading state that hides the login button and thereby unmounts the login modal, oops!
This commit is contained in:
Emi Matchu 2022-08-26 16:03:47 -07:00
parent 92ade4a513
commit 39852c8297
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/app/components/LoginModal.js
View file

@ -78,11 +78,11 @@ function LoginForm({ onSuccess }) {
// I don't do any optimistic UI here, because auth is complex enough // I don't do any optimistic UI here, because auth is complex enough
// that I'd rather only show login success after validating it through // that I'd rather only show login success after validating it through
// an actual server round-trip. // an actual server round-trip.
cache.evict({ id: "ROOT_QUERY", fieldName: "currentUser" });
if (data.login?.id != null) { if (data.login?.id != null) {
cache.evict({ id: "ROOT_QUERY", fieldName: "currentUser" });
cache.evict({ id: `User:${data.login.id}` }); cache.evict({ id: `User:${data.login.id}` });
}
cache.gc(); cache.gc();
}
}, },
} }
); );
@ -99,7 +99,7 @@ function LoginForm({ onSuccess }) {
onSuccess(); onSuccess();
} }
}) })
.catch((e) => {}); // handled in error UI .catch((e) => console.error(e)); // plus the error UI
}} }}
> >
<FormControl> <FormControl>