OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

Oops, fix items drawn for multiple colors

Browse source 
Just a little display bug on the homepage. For an item like the "Evil Coconut Half Mask", which was specifically drawn for the standard _and_ major special colors, our previous logic would have said "Baby only" or "Maraquan only" or whatever special color it happened to find first.

Now, we only show the case "Baby only" if it _doesn't_ fit standard pets too.

Note that the Maraquan case is tricky, because the Blue Mynci can also wear Maraquan items lol! For this reason, we check for two standard bodies before declaring that it's meant for standard pets.
This commit is contained in:
Emi Matchu 2021-07-11 21:27:24 -07:00
parent a1f3c1df13
commit 29ca2306af
1 changed files with 28 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
src/app/HomePage.js
View file

@ -375,7 +375,19 @@ function NewItemsSectionContent() {
const { loading, error, data } = useQuery(
gql`
query NewItemsSection {
newestItems {
newestItems: items(
ids: [
"81546"
"35082"
"75149"
"81797"
"58741"
"78953"
"82427"
"82727"
"82726"
]
) {
id
name
thumbnailUrl
@ -488,6 +500,9 @@ function NewItemsSectionContent() {
}
function ItemModelingSummary({ item }) {
// NOTE: To test this logic, I like to swap out `newestItems` in the query:
// `newestItems: items(ids: ["81546", "35082", "75149", "81797", "58741", "78953", "82427", "82727", "82726"])`
if (item.speciesThatNeedModels.length > 0) {
return (
<Box fontSize="xs" fontStyle="italic" fontWeight="600" opacity="0.8">
@ -507,9 +522,19 @@ function ItemModelingSummary({ item }) {
);
}
// HACK: The Maraquan Mynci and the Blue Mynci have the same body, so to test
// whether something is *meant* for standard colors, we check for more
// than
const standardBodies = bodies.filter(
(b) => b.canonicalAppearance.color.isStandard
);
const isMeantForStandardBodies = standardBodies.length >= 2;
const colors = bodies.map((b) => b.canonicalAppearance.color);
const specialColor = colors.find((c) => !c.isStandard);
if (specialColor && bodies.length === 1) {
const hasSpecialColorOnly = !isMeantForStandardBodies && specialColor != null;
if (hasSpecialColorOnly && bodies.length === 1) {
return (
<Box fontSize="xs" fontStyle="italic" opacity="0.8">
{specialColor.name} {bodies[0].species.name} only
@ -525,7 +550,7 @@ function ItemModelingSummary({ item }) {
);
}
if (specialColor) {
if (hasSpecialColorOnly) {
return (
<Box fontSize="xs" fontStyle="italic" opacity="0.8">
{specialColor.name} only