OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

remove flicker when opening the pose picker

Browse source
This commit is contained in:
Matt Dunn-Rankin 2020-05-03 00:15:03 -07:00
parent 6c4569656f
commit 2214fe2815
2 changed files with 20 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
src/app/OutfitPreview.js
View file

@ -1,5 +1,5 @@
import React from "react"; import React from "react";
import { css } from "emotion"; import { css, cx } from "emotion";
import { CSSTransition, TransitionGroup } from "react-transition-group"; import { CSSTransition, TransitionGroup } from "react-transition-group";
import { Box, Flex, Icon, Image, Spinner, Text } from "@chakra-ui/core"; import { Box, Flex, Icon, Image, Spinner, Text } from "@chakra-ui/core";
@ -39,6 +39,10 @@ function OutfitPreview({ outfitState }) {
* used both in the main outfit preview, and in other minor UIs! * used both in the main outfit preview, and in other minor UIs!
*/ */
export function OutfitLayers({ loading, visibleLayers, doAnimations = false }) { export function OutfitLayers({ loading, visibleLayers, doAnimations = false }) {
// If we're fading in, we should use Image, to detect the load success. But
// if not, just use a plain img, so that we load instantly without a flicker!
const ImageTag = doAnimations ? Image : "img";
return ( return (
<Box pos="relative" height="100%" width="100%"> <Box pos="relative" height="100%" width="100%">
<TransitionGroup enter={false} exit={doAnimations}> <TransitionGroup enter={false} exit={doAnimations}>
@ -60,25 +64,28 @@ export function OutfitLayers({ loading, visibleLayers, doAnimations = false }) {
timeout={200} timeout={200}
> >
<FullScreenCenter> <FullScreenCenter>
<Image <ImageTag
src={layer.imageUrl} src={layer.imageUrl}
objectFit="contain"
maxWidth="100%"
maxHeight="100%"
// We manage the fade-in and fade-out separately! The fade-in // We manage the fade-in and fade-out separately! The fade-in
// happens here, when the <Image> finishes preloading and // happens here, when the <Image> finishes preloading and
// applies the src to the underlying <img>. // applies the src to the underlying <img>.
className={ className={cx(
doAnimations &&
css` css`
opacity: 0.01; object-fit: contain;
max-width: 100%;
max-height: 100%;
&[src] { transition: opacity 0.2s;
opacity: 1; &.do-animations {
transition: opacity 0.2s; opacity: 0.01;
} }
`
} &.do-animations[src] {
opacity: 1;
}
`,
doAnimations && "do-animations"
)}
// This sets up the cache to not need to reload images during // This sets up the cache to not need to reload images during
// download! // download!
// TODO: Re-enable this once we get our change into Chakra // TODO: Re-enable this once we get our change into Chakra

1
src/app/PosePicker.js
View file

@ -6,7 +6,6 @@ import {
Box, Box,
Button, Button,
Flex, Flex,
Image,
Popover, Popover,
PopoverArrow, PopoverArrow,
PopoverContent, PopoverContent,