OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

don't cache poses for Support tool

Browse source 
I noticed in prod that the Vercel edge cache can show old data in the Support tool right after you edit it and reload the page, which is super confusing!

In this change, we stop caching the endpoint we use for Support tools, so that the Support tools always feel real-time and trustworthy. (The standard pose picker might still be cached, so it could be a bit confusing for that to be out of sync, but at least you can toggle into Support mode and see that your changes happened _there_, so you don't panic that they're _gone_.)
This commit is contained in:
Emi Matchu 2020-08-31 01:17:18 -07:00
parent 2cc643fd4c
commit 214a93008b
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/server/index.js
View file

@ -224,9 +224,11 @@ const typeDefs = gql`
@cacheControl(maxAge: 10800) # Cache for 3 hours (we might model more!) @cacheControl(maxAge: 10800) # Cache for 3 hours (we might model more!)
# All pet appearances we've ever seen for the given species and color. Note # All pet appearances we've ever seen for the given species and color. Note
# that this might include multiple copies for the same pose, and they might # that this might include multiple copies for the same pose, and they might
# even be glitched data. We use this for Support tools. # even be glitched data. We use this for Support tools, and we don't cache
# it to make sure that Support users are always seeing the most up-to-date
# version here (even if the standard pose picker is still showing outdated
# cached canonical poses).
petAppearances(speciesId: ID!, colorId: ID!): [PetAppearance!]! petAppearances(speciesId: ID!, colorId: ID!): [PetAppearance!]!
@cacheControl(maxAge: 10800) # Cache for 3 hours (we might model more!)
outfit(id: ID!): Outfit outfit(id: ID!): Outfit
petOnNeopetsDotCom(petName: String!): Outfit petOnNeopetsDotCom(petName: String!): Outfit