OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

Skip missing image layers in /api/outfitImage

Browse source 
Sometimes we don't have an image for an SWF asset. This can happen when
assets were converted to HTML5 without a PNG specified in the manifest.
(One example is bio/363, the Hind Biology for the Mutant Blumaroo.)

I'm noticing there's a second issue here on DTI's end, where it looks
like *we* have two copies of certain layers? I wonder if this was a bug
in like, the impress-2020 modeling code we tested at one point? Or if
this is in our main modeling code? e.g. the Mutant Blumaroo's bio/363
is in our database with DTI ID 192 and DTI ID 606955, and only the
former is registered as having an image (which we made ourselves and
host on S3).

So, I'm gonna start by just having the more graceful failure mode of
skipping the missing layer. But I'm also concerned about the root here,
I'll investigate!
This commit is contained in:
Emi Matchu 2024-02-09 08:59:36 -08:00
parent 8fb561338a
commit 0e1b1eded3
1 changed files with 12 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
pages/api/outfitImage.js
View file

@ -84,7 +84,7 @@ async function handle(req, res) {
return reject( return reject(
res, res,
`Error loading data for outfit ${outfitId}: ${e.message}`, `Error loading data for outfit ${outfitId}: ${e.message}`,
500 500,
); );
} }
} else if (req.query.id) { } else if (req.query.id) {
@ -101,7 +101,7 @@ async function handle(req, res) {
return reject( return reject(
res, res,
`Error loading data for outfit ${outfitId}: ${e.message}`, `Error loading data for outfit ${outfitId}: ${e.message}`,
500 500,
); );
} }
@ -188,7 +188,7 @@ async function loadLayerUrlsForSavedOutfit(outfitId, size) {
if (errors && errors.length > 0) { if (errors && errors.length > 0) {
throw new Error( throw new Error(
`GraphQL Error: ${errors.map((e) => e.message).join(", ")}` `GraphQL Error: ${errors.map((e) => e.message).join(", ")}`,
); );
} }
@ -197,17 +197,20 @@ async function loadLayerUrlsForSavedOutfit(outfitId, size) {
} }
const { petAppearance, itemAppearances } = data.outfit; const { petAppearance, itemAppearances } = data.outfit;
const visibleLayers = getVisibleLayers(petAppearance, itemAppearances);
const visibleLayers = getVisibleLayers(petAppearance, itemAppearances);
visibleLayers.sort((a, b) => a.depth - b.depth);
const imageUrls = [];
for (const layer of visibleLayers) { for (const layer of visibleLayers) {
if (!layer.imageUrl) { if (!layer.imageUrl) {
throw new Error(`layer ${layer.id} has no imageUrl for size ${size}`); console.warn(`layer ${layer.id} has no imageUrl for size ${size}`);
continue;
} }
imageUrls.push(layer.imageUrl);
} }
return visibleLayers return imageUrls;
.sort((a, b) => a.depth - b.depth)
.map((layer) => layer.imageUrl);
} }
async function loadUpdatedAtForSavedOutfit(outfitId) { async function loadUpdatedAtForSavedOutfit(outfitId) {
@ -230,7 +233,7 @@ function reject(res, message, status = 400) {
async function handleWithBeeline(req, res) { async function handleWithBeeline(req, res) {
beeline.withTrace( beeline.withTrace(
{ name: "api/outfitImage", operation_name: "api/outfitImage" }, { name: "api/outfitImage", operation_name: "api/outfitImage" },
() => handle(req, res) () => handle(req, res),
); );
} }