OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity

fix bug querying depth on restricted zones

Browse source
This commit is contained in:
Matt Dunn-Rankin 2020-05-31 16:08:17 -07:00
parent caefc6610c
commit 03cde98eae
2 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/server/index.js
View file

@ -272,8 +272,15 @@ const resolvers = {
},
},
Zone: {
label: async (zone, _, { zoneTranslationLoader }) => {
const zoneTranslation = await zoneTranslationLoader.load(zone.id);
depth: async ({ id }, _, { zoneLoader }) => {
// TODO: Should we extend this loader-in-field pattern elsewhere? I like
// that we avoid the fetch in cases where we only want the zone ID,
// but it adds complexity 🤔
const zone = await zoneLoader.load(id);
return zone.depth;
},
label: async ({ id }, _, { zoneTranslationLoader }) => {
const zoneTranslation = await zoneTranslationLoader.load(id);
return zoneTranslation.label;
},
},

5
src/server/loaders.js
View file

@ -256,7 +256,8 @@ const buildZoneLoader = (db) =>
return ids.map(
(id) =>
entitiesById.get(id) || new Error(`could not find zone with ID: ${id}`)
entitiesById.get(String(id)) ||
new Error(`could not find zone with ID: ${id}`)
);
});
@ -273,7 +274,7 @@ const buildZoneTranslationLoader = (db) =>
return zoneIds.map(
(zoneId) =>
entitiesByZoneId.get(zoneId) ||
entitiesByZoneId.get(String(zoneId)) ||
new Error(`could not find translation for zone ${zoneId}`)
);
});