OpenNeo/impress-2020
OpenNeo/impress-2020
1
0
Fork 0
Code Pull requests Activity
impress-2020/src/server/query-tests/Item.test.js

589 lines
14 KiB
JavaScript
Raw Normal View History

split query tests into separately runnable files!
2020-04-25 23:03:58 -07:00
const gql = require("graphql-tag");
const { query, getDbCalls } = require("./setup.js");
describe("Item", () => {
it("loads metadata", async () => {
const res = await query({
query: gql`
query {
add explicitlyBodySpecific to Item GQL for the upcoming Support feature!
2020-08-14 21:12:13 -07:00
items(ids: ["38913", "38911", "38912", "55788", "77530", "78104"]) {
split query tests into separately runnable files!
2020-04-25 23:03:58 -07:00
id
name
description
thumbnailUrl
add rarityIndex, isNc to API
2020-05-31 15:56:40 -07:00
rarityIndex
isNc
show the actual manual special color in support UI
2020-07-31 22:31:28 -07:00
manualSpecialColor {
id
name
}
add explicitlyBodySpecific to Item GQL for the upcoming Support feature!
2020-08-14 21:12:13 -07:00
explicitlyBodySpecific
split query tests into separately runnable files!
2020-04-25 23:03:58 -07:00
}
}
`,
});
expect(res).toHaveNoErrors();
expect(res.data).toMatchSnapshot();
expect(getDbCalls()).toMatchInlineSnapshot(`
Array [
Array [
add explicitlyBodySpecific to Item GQL for the upcoming Support feature!
2020-08-14 21:12:13 -07:00
"SELECT * FROM item_translations WHERE item_id IN (?,?,?,?,?,?) AND locale = \\"en\\"",
split query tests into separately runnable files!
2020-04-25 23:03:58 -07:00
Array [
"38913",
"38911",
"38912",
add explicitlyBodySpecific to Item GQL for the upcoming Support feature!
2020-08-14 21:12:13 -07:00
"55788",
show the actual manual special color in support UI
2020-07-31 22:31:28 -07:00
"77530",
add rarityIndex, isNc to API
2020-05-31 15:56:40 -07:00
"78104",
split query tests into separately runnable files!
2020-04-25 23:03:58 -07:00
],
],
Array [
add explicitlyBodySpecific to Item GQL for the upcoming Support feature!
2020-08-14 21:12:13 -07:00
"SELECT * FROM items WHERE id IN (?,?,?,?,?,?)",
split query tests into separately runnable files!
2020-04-25 23:03:58 -07:00
Array [
"38913",
"38911",
"38912",
add explicitlyBodySpecific to Item GQL for the upcoming Support feature!
2020-08-14 21:12:13 -07:00
"55788",
show the actual manual special color in support UI
2020-07-31 22:31:28 -07:00
"77530",
add rarityIndex, isNc to API
2020-05-31 15:56:40 -07:00
"78104",
split query tests into separately runnable files!
2020-04-25 23:03:58 -07:00
],
],
show the actual manual special color in support UI
2020-07-31 22:31:28 -07:00
Array [
"SELECT * FROM color_translations
WHERE color_id IN (?) AND locale = \\"en\\"",
Array [
"44",
],
],
split query tests into separately runnable files!
2020-04-25 23:03:58 -07:00
]
`);
});
it("loads appearance data", async () => {
const res = await query({
query: gql`
query {
items(ids: ["38912", "38911", "37375"]) {
id
name
appearanceOn(speciesId: "54", colorId: "75") {
layers {
id
add Neopets ID to layer support modal
2020-08-14 22:09:52 -07:00
remoteId
split query tests into separately runnable files!
2020-04-25 23:03:58 -07:00
imageUrl(size: SIZE_600)
skip non-SWF (music) assets
2020-05-27 00:46:55 -07:00
svgUrl
split query tests into separately runnable files!
2020-04-25 23:03:58 -07:00
zone {
id
depth
label
}
}
restrictedZones {
id
}
}
}
}
`,
});
expect(res).toHaveNoErrors();
expect(res.data).toMatchSnapshot();
expect(getDbCalls()).toMatchInlineSnapshot(`
Array [
Array [
oops, fix isNc and stop loading items early!
2020-07-02 20:06:04 -07:00
"SELECT * FROM item_translations WHERE item_id IN (?,?,?) AND locale = \\"en\\"",
split query tests into separately runnable files!
2020-04-25 23:03:58 -07:00
Array [
"38912",
"38911",
"37375",
],
],
Array [
fix caching for petTypeLoader Oops, of course, we weren't actually taking proper advantage of the dataloader here! The queries got over-complicated, but more importantly, subsequent requests to the same loader would re-submit the query! I noticed it in the SearchPanel operation, in this Honeycomb trace: https://ui.honeycomb.io/openneo/datasets/dress-to-impress--2020-/trace/aMuhsTjQFZY
2020-08-17 01:33:34 -07:00
"SELECT * FROM pet_types WHERE (species_id = ? AND color_id = ?)",
split query tests into separately runnable files!
2020-04-25 23:03:58 -07:00
Array [
"54",
"75",
],
],
Array [
"SELECT sa.*, rel.parent_id FROM swf_assets sa
INNER JOIN parents_swf_assets rel ON
rel.parent_type = \\"Item\\" AND
rel.swf_asset_id = sa.id
WHERE (rel.parent_id = ? AND (sa.body_id = ? OR sa.body_id = 0)) OR (rel.parent_id = ? AND (sa.body_id = ? OR sa.body_id = 0)) OR (rel.parent_id = ? AND (sa.body_id = ? OR sa.body_id = 0))",
Array [
"38912",
"180",
"38911",
"180",
"37375",
"180",
],
],
add id to ItemAppearance (+ refactor) This is in support of a caching issue in a hack tool coming next! Without this, the change to ItemAppearance restricted zones would make other ItemAppearance fields go missing (bc our hack tool didn't also specify them), so the query would re-execute over the network to find the missing fields we overwrote with nothingness—which would undo the local hack change.
2020-08-28 00:10:00 -07:00
Array [
"SELECT * FROM items WHERE id IN (?,?,?)",
Array [
"38912",
"38911",
"37375",
],
],
Revert "cache zone data" This reverts commit 0f7ab9d10e5f805b284188d1a7c093f9a21dfbe8. The Production Vercel deploys don't seem to like how I did this build trick, even though the Preview deploys seem fine with it 🤔 Reverting for now, sent a message to Vercel support.
2020-08-17 18:49:37 -07:00
Array [
"SELECT * FROM zones WHERE id IN (?,?,?)",
Array [
"26",
"40",
"3",
],
],
Array [
"SELECT * FROM zone_translations WHERE zone_id IN (?,?,?) AND locale = \\"en\\"",
Array [
"26",
"40",
"3",
],
],
split query tests into separately runnable files!
2020-04-25 23:03:58 -07:00
]
`);
});
skip non-SWF (music) assets
2020-05-27 00:46:55 -07:00
don't restrict zones if the item is not compatible Previously, if you switched species/color such that one of your items was no longer compatible, we _would_ still apply its zone restrictions to the visible layer set. In this change, we fix that server-side, since I think it makes the most sense for an empty appearance to be truly empty!
2020-09-01 17:00:27 -07:00
it("returns empty appearance for incompatible items", async () => {
const res = await query({
query: gql`
query {
items(ids: ["38912"]) {
id
name
appearanceOn(speciesId: "1", colorId: "8") {
layers {
id
}
# Pay particular attention to this: normally this item restricts
# zones, but not when the appearance is empty!
restrictedZones {
id
}
}
}
}
`,
});
expect(res).toHaveNoErrors();
expect(res.data).toMatchInlineSnapshot(`
Object {
"items": Array [
Object {
"appearanceOn": Object {
"layers": Array [],
"restrictedZones": Array [],
},
"id": "38912",
"name": "Zafara Agent Robe",
},
],
}
`);
expect(getDbCalls()).toMatchInlineSnapshot(`
Array [
Array [
"SELECT * FROM item_translations WHERE item_id IN (?) AND locale = \\"en\\"",
Array [
"38912",
],
],
Array [
"SELECT * FROM pet_types WHERE (species_id = ? AND color_id = ?)",
Array [
"1",
"8",
],
],
Array [
"SELECT sa.*, rel.parent_id FROM swf_assets sa
INNER JOIN parents_swf_assets rel ON
rel.parent_type = \\"Item\\" AND
rel.swf_asset_id = sa.id
WHERE (rel.parent_id = ? AND (sa.body_id = ? OR sa.body_id = 0))",
Array [
"38912",
"93",
],
],
]
`);
});
skip non-SWF (music) assets
2020-05-27 00:46:55 -07:00
it("skips appearance data for audio assets", async () => {
const res = await query({
query: gql`
query {
items(ids: ["42829"]) {
id
name
appearanceOn(speciesId: "54", colorId: "75") {
layers {
id
imageUrl(size: SIZE_600)
svgUrl
zone {
id
depth
label
}
}
restrictedZones {
id
}
}
}
}
`,
});
expect(res).toHaveNoErrors();
expect(res.data).toMatchSnapshot();
expect(getDbCalls()).toMatchInlineSnapshot(`
Array [
Array [
oops, fix isNc and stop loading items early!
2020-07-02 20:06:04 -07:00
"SELECT * FROM item_translations WHERE item_id IN (?) AND locale = \\"en\\"",
skip non-SWF (music) assets
2020-05-27 00:46:55 -07:00
Array [
"42829",
],
],
Array [
"SELECT * FROM pet_types WHERE (species_id = ? AND color_id = ?)",
Array [
"54",
"75",
],
],
Array [
"SELECT sa.*, rel.parent_id FROM swf_assets sa
INNER JOIN parents_swf_assets rel ON
rel.parent_type = \\"Item\\" AND
rel.swf_asset_id = sa.id
WHERE (rel.parent_id = ? AND (sa.body_id = ? OR sa.body_id = 0))",
Array [
"42829",
"180",
],
],
add id to ItemAppearance (+ refactor) This is in support of a caching issue in a hack tool coming next! Without this, the change to ItemAppearance restricted zones would make other ItemAppearance fields go missing (bc our hack tool didn't also specify them), so the query would re-execute over the network to find the missing fields we overwrote with nothingness—which would undo the local hack change.
2020-08-28 00:10:00 -07:00
Array [
"SELECT * FROM items WHERE id IN (?)",
Array [
"42829",
],
],
skip non-SWF (music) assets
2020-05-27 00:46:55 -07:00
]
`);
});
add GQL endpoint for items that need models
2020-09-06 02:50:04 -07:00
it("loads items that need models", async () => {
jest.setTimeout(20000);
in-memory cache for modeling query I'm using my first ever MySQL Store Procedure for clever cleverness in caching the modeling query! I realized that checking for the latest contribution timestamp is a pretty reliable way of deciding when modeling data was last updated at all. If that timestamp hasn't changed, we can reuse the results! I figured that, because query roundtrips are a bottleneck in this environment, I didn't want to make that query separately. So, I built a MySQL procedure to do the check on the database side!
2020-09-06 15:49:08 -07:00
const buildLoaders = require("../loaders");
const db = await require("../db")();
const { itemsThatNeedModelsLoader } = buildLoaders(db);
await itemsThatNeedModelsLoader.load("all");
add GQL endpoint for items that need models
2020-09-06 02:50:04 -07:00
const res = await query({
query: gql`
query {
itemsThatNeedModels {
id
name
speciesThatNeedModels {
id
name
}
}
}
`,
});
expect(res).toHaveNoErrors();
expect(res.data).toMatchSnapshot();
expect(getDbCalls()).toMatchInlineSnapshot(`
Array [
Array [
"
SELECT items.id,
GROUP_CONCAT(DISTINCT pet_types.species_id ORDER BY pet_types.species_id)
AS modeled_species_ids,
-- Vandagyre was added on 2014-11-14, so we add some buffer here.
-- TODO: Some later Dyeworks items don't support Vandagyre.
-- Add a manual db flag?
items.created_at >= \\"2014-12-01\\" AS supports_vandagyre
FROM items
INNER JOIN parents_swf_assets psa
ON psa.parent_type = \\"Item\\" AND psa.parent_id = items.id
INNER JOIN swf_assets
ON swf_assets.id = psa.swf_asset_id
INNER JOIN pet_types
ON pet_types.body_id = swf_assets.body_id
WHERE
pet_types.color_id = \\"8\\"
GROUP BY items.id
HAVING
NOT (
-- Single species (probably just their item)
count(DISTINCT pet_types.species_id) = 1
-- All species modeled
OR modeled_species_ids = \\"1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55\\"
-- All species modeled except Vandagyre, for items that don't support it
OR (NOT supports_vandagyre AND modeled_species_ids = \\"1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54\\")
-- No species (either an All Bodies item, or a Capsule type thing)
OR modeled_species_ids = \\"\\"
)
ORDER BY items.id
",
],
Array [
"SELECT * FROM item_translations WHERE item_id IN (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?) AND locale = \\"en\\"",
Array [
"24534",
"33850",
"34167",
"36125",
"36126",
"36245",
"36678",
"36729",
"36907",
"37354",
"37368",
"37840",
"38003",
"38130",
"38214",
"38216",
"38225",
"38311",
"38314",
"38391",
"39147",
"39148",
"39149",
"39313",
"39817",
"39884",
"41216",
"41690",
"41691",
"42169",
"42171",
"42448",
"42449",
"42475",
"42478",
"42544",
"42546",
"42823",
"42885",
"42886",
"42993",
"42994",
"43079",
"43081",
"43677",
"43694",
"44456",
"44507",
"45301",
"47054",
"47066",
"49408",
"50669",
"50670",
"50671",
"50672",
"51646",
"51651",
"51653",
"51654",
"51655",
"52684",
"53063",
"53324",
"53325",
"53762",
"53818",
"53820",
"54436",
"55596",
"55673",
"55675",
"56717",
"57295",
"58285",
"59848",
"60751",
"62302",
"62939",
"63077",
"63464",
"64195",
"64387",
"66493",
"67317",
"68228",
"68293",
"68470",
"69311",
"69743",
"69748",
"69754",
"69755",
"69756",
"69761",
"69772",
"69773",
"69782",
"69998",
"70843",
"71110",
"71658",
"71937",
"71938",
"72188",
"72553",
"72897",
"72898",
"72899",
"72906",
"72907",
"72908",
"72912",
"72913",
"72914",
"73094",
"73405",
"73598",
"73707",
"73708",
"73724",
"73766",
"74055",
"74259",
"74260",
"74261",
"74314",
"74315",
"75197",
"75198",
"75199",
"76108",
"76109",
"77441",
"77442",
"78318",
"78320",
"78560",
"78754",
"79847",
"80024",
"80427",
"80428",
"80774",
"81060",
"81061",
"81062",
"81144",
"81145",
"81229",
"81230",
"81232",
"81233",
"81234",
"81237",
"81238",
"81240",
"81241",
"81242",
"81243",
"81245",
"81246",
"81274",
"81371",
"81396",
"81547",
"81563",
"81630",
],
],
Array [
"SELECT * FROM species_translations
WHERE species_id IN (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?) AND locale = \\"en\\"",
Array [
"18",
"24",
"25",
"48",
"49",
"20",
"6",
"27",
"41",
"42",
"5",
"47",
"50",
"51",
"4",
"11",
"12",
"14",
"23",
"37",
"21",
"1",
"7",
"8",
"15",
"16",
"17",
"19",
"22",
"26",
"30",
"32",
"34",
"36",
"39",
"40",
"44",
"54",
"31",
"33",
"3",
"9",
"28",
"29",
"35",
"38",
"43",
"45",
"46",
"52",
"53",
"2",
"10",
"13",
"55",
],
],
]
`);
});
split query tests into separately runnable files!
2020-04-25 23:03:58 -07:00
});
Copy permalink